Testing API to block for compaction#6511
Open
mihaibudiu wants to merge 2 commits into
Open
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mythical-fred
approved these changes
Jun 20, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM — clean API extension, solid test.
mythical-fred
approved these changes
Jun 20, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Re-approve. DbspError::Runtime swap addresses my prior nit on the timeout-error variant. New per-worker IsCompactionComplete round-trip and Java BlockForCompaction command are clean.
One small doc nit inline.
| /// to a cap of 1 s. | ||
| /// | ||
| /// Returns `Ok(())` when compaction is complete, or | ||
| /// Error the timeout expires. |
There was a problem hiding this comment.
Nit: doc-comment grammar — "Error the timeout expires" should be "Returns Err([DbspError::Runtime]) when the timeout expires." or simply "Errors when the timeout expires." (Missing verb.)
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2808
Adds a new DBSP-level API for a circuit to wait for compaction to terminate in all workers.
Adds SQL compiler support for writing tests using this API. I expect all tests that relate to GC will use this API heavily.
Describe Manual Test Plan
Tested the new Java test
Checklist