[web-console] Sort metrics lexicographically inside each block#6474
Open
Karakatiza666 wants to merge 1 commit into
Open
[web-console] Sort metrics lexicographically inside each block#6474Karakatiza666 wants to merge 1 commit into
Karakatiza666 wants to merge 1 commit into
Conversation
Closes #6406. The metrics tab grouped metrics by category but listed them in discovery order, forcing readers to scan an entire block to find a specific metric. Sort each block's entries by their displayed label with a locale-aware, natural-number-aware collator so e.g. `slot 2` precedes `slot 10`. Adds a vitest setup to profiler-layout (jsdom environment, since profiler-lib's main entry pulls in cytoscape modules that touch `window`) and unit tests covering the alphabetisation and the natural-number ordering case. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
mythical-fred
approved these changes
Jun 15, 2026
| "@tailwindcss/vite": "^4.1.17", | ||
| "@vitest/browser-playwright": "^4.1.8", | ||
| "feldera-theme": "workspace:*", | ||
| "jsdom": "^29.1.1", |
There was a problem hiding this comment.
Nit: jsdom is added to devDependencies, but vitest.config.ts already runs in real Chromium via @vitest/browser-playwright and this test only exercises pure logic. Is jsdom actually required by something, or can this dep be dropped?
mihaibudiu
approved these changes
Jun 15, 2026
|
|
||
| function makeAttrs(metrics: string[]): NodeAttributes { | ||
| return { | ||
| title: 'n op', |
Contributor
There was a problem hiding this comment.
I cannot guess what this is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sorting of each block's entries by their displayed label with a locale-aware, natural-number-aware comparison so e.g.
slot 2precedesslot 10.Testing: manual, added unit tests
Fix #6406