[web-console] ad-hoc: format invalid number values as-is, not as 'null'#6473
Open
Karakatiza666 wants to merge 1 commit into
Open
[web-console] ad-hoc: format invalid number values as-is, not as 'null'#6473Karakatiza666 wants to merge 1 commit into
Karakatiza666 wants to merge 1 commit into
Conversation
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
mihaibudiu
reviewed
Jun 15, 2026
| } | ||
| if (!Array.isArray(value)) { | ||
| return JSONbig.stringify(value, undefined, 1) | ||
| return formatNonFiniteNumber(value) ?? JSONbig.stringify(value, undefined, 1) |
Contributor
There was a problem hiding this comment.
what if this is a ROW value? Or a Map value?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NaN/Inf values were formatted by a JSON.stringify() that prints
nullin these cases; now detecting such values and serializing them as-is. Valid numbers are still serialized with JSON.stringify downstreamFix #6341
Testing: manual, added unit tests