[SQL] Support for svg output#6453
Queued
mihaibudiu wants to merge 2 commits into
Queued
Conversation
anandbraman
approved these changes
Jun 11, 2026
009ac4d to
ffc963b
Compare
mythical-fred
approved these changes
Jun 11, 2026
mythical-fred
approved these changes
Jun 12, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM — prior nit (emitPng missing from toString()) is fixed, validation properly covers all three image formats now.
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6451
Fixes #6443
Fixes #6342
Fixes #5398
Bumped Calcite, which should fix issues 2-4.
Describe Manual Test Plan
I actually did generate an svg output.
This is not tested in ci because there is usually no graphviz binary installed on the ci machines.
Checklist