pipeline-manager: deprecate unstable feature cluster_monitor_resources#6414
Merged
Conversation
gz
approved these changes
Jun 6, 2026
Contributor
|
does it make sense to have an opt-out option? public deployments? |
Contributor
|
Can we merge this? It has conflicts now |
Contributor
Author
|
I still need to add the opt-out variant |
snkas
force-pushed
the
deprecate-unstable-feature-cluster-resources
branch
from
July 6, 2026 14:05
1fb9e73 to
891b7f0
Compare
Contributor
Author
|
I added opt-out with a new unstable feature: |
mythical-fred
approved these changes
Jul 6, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
The design shift from "remove the gate entirely" to "keep the gate but invert its polarity to opt-out" is a nicer path — enables the useful default while still leaving an escape hatch for operators who need to silence the resource poller (e.g. RBAC-restricted deployments). Logic branches are correctly flipped, feature list, changelog, helm reference, and tutorial doc are all updated consistently. LGTM.
Two very minor nits, non-blocking:
- Changelog: "Cluster monitor events ... is no longer gated" → should be "are no longer gated" (subject is plural).
helm-chart-reference.md: theunstableFeaturesrow now lists only"testing","runtime_version","disable_cluster_monitor_resources", butplatform_enable_unstablealso accepts"rust_compiler_full_cleanup". Pre-existing gap — worth fixing in a follow-up so the reference stays in sync withall_features.
snkas
force-pushed
the
deprecate-unstable-feature-cluster-resources
branch
3 times, most recently
from
July 10, 2026 08:09
b9ce837 to
c900b3a
Compare
snkas
enabled auto-merge
July 10, 2026 08:10
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 10, 2026
The backing (Kubernetes) resources information is now enabled by default for the cluster monitoring events. It can still be disabled by passing `--disable-cluster-monitor-resources` as argument.
snkas
force-pushed
the
deprecate-unstable-feature-cluster-resources
branch
from
July 10, 2026 08:57
c900b3a to
392f823
Compare
snkas
enabled auto-merge
July 10, 2026 08:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backing (Kubernetes) resources information is now enabled by default for the cluster monitoring events. It can still be disabled by passing
--disable-cluster-monitor-resourcesas argument.PR information