[WIP] adapters: handle deletion vector in delta input connector#6391
Open
swanandx wants to merge 1 commit into
Open
[WIP] adapters: handle deletion vector in delta input connector#6391swanandx wants to merge 1 commit into
swanandx wants to merge 1 commit into
Conversation
508a0fc to
0576337
Compare
snapshot mode works fine with deletion vectors, but for follow mode we need parse and apply deletion vector ourselves to read parquet files, same with some cases in cdc mode Signed-off-by: Swanand Mulay <73115739+swanandx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
PR is work in progress
snapshot mode works fine with deletion vectors, but for follow mode we need parse and apply deletion vector ourselves to read parquet files, same with some cases in cdc mode
Describe Manual Test Plan
Checklist
Breaking Changes?
Not breaking change