adapters: use dataframes instead of sql strings#6245
Merged
Conversation
This was prompted by an errornous SQL injection report. While those arent really security vulnerabilities here because there is no point where this can get injected by an untrusted source, it still seemed more ergonomic to transform this into data-frame API calls when looking at it. I think it also enhances error reporting in some cases. Adds a few more tests. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was prompted by some invalid SQL injection reporter.
While nothing here exposed a real "sql injection" (because there is no point where an untrusted source can write a connector config), it still seemed more ergonomic to transform this into the data-frame API when looking at it.
I think it also enhances error reporting in some cases. The PR adds a few more tests.
Checklist
Breaking Changes?
Ideally none.