Skip to content

Adjust phrasing and naming in multiple UI elements #6238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Karakatiza666 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adjust phrasing and naming in multiple UI elements #6238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion js-packages/web-console/src/lib/components/dialogs/GenericDialog.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@
danger,
disabled,
noclose,
swapActions,
children
}: {
content: GlobalDialogContent
danger?: boolean
disabled?: boolean
/** When set, the dialog has no "X" button and does not auto-close on cancel/click-away. */
noclose?: boolean
swapActions?: boolean
children?: Snippet
} = $props()

Expand Down Expand Up @@ -67,11 +69,12 @@
<button
onclick={() => cancel()}
class="btn preset-filled-surface-50-950 px-4"
class:order-last={swapActions}
data-testid="btn-dialog-cancel"
>
{content.onCancel?.name ?? 'Cancel'}
</button>
<div>
<div class:order-first={swapActions}>
<button
{disabled}
onclick={content.onSuccess.callback}
Expand Down
2 changes: 1 addition & 1 deletion js-packages/web-console/src/lib/components/layout/pipelines/PipelineEditLayout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@
{ icon: 'fd fd-panel-bottom', text: 'Monitoring', value: showMonitoringPanel },
{
icon: 'fd fd-panel-right',
text: 'Interaction',
text: 'Inspect',
value: showInteractionPanel,
show: isScreenLg.current
}
Expand Down
2 changes: 1 addition & 1 deletion js-packages/web-console/src/lib/components/pipelines/editor/MonitoringPanel.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@

{#snippet TabControlChangeStream()}
<span class="inline sm:hidden"> Changes </span>
<span class="hidden sm:inline"> Changes Stream </span>
<span class="hidden sm:inline"> Change Stream </span>
{/snippet}

{#snippet TabHealth()}
Expand Down
3 changes: 1 addition & 2 deletions js-packages/web-console/src/lib/components/pipelines/editor/TabPerformance.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,7 @@
</script>

{#snippet label()}
<span class="inline sm:hidden"> Perf </span>
<span class="hidden sm:inline"> Performance </span>
Runtime
{/snippet}

{#if isMetricsAvailable(pipeline.current.status) === 'no'}
Expand Down
5 changes: 3 additions & 2 deletions ...kages/web-console/src/lib/components/pipelines/editor/performance/CheckpointDialog.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@

<GenericDialog
content={{
title: 'Checkpoint the current pipeline state',
title: 'Create a checkpoint?',
description:
'Create the checkpoint? This may delete the oldest checkpoint, and will temporarily increase load on the pipeline.',
'This may delete the oldest checkpoint and briefly increase pipeline load.',
onSuccess: {
name: 'Checkpoint',
'data-testid': 'btn-confirm-checkpoint',
Expand All @@ -21,4 +21,5 @@
}
}
}}
swapActions
></GenericDialog>
Loading