Conversation
Don't pause inputs if a checkpoint has already started: once it has started, the checkpoint may be processing in a background thread but this shouldn't stop the pipeline from processing inputs. Previously, only CheckpointBarrier inputs would be processed in this situation, preventing most inputs from being processed and stalling the pipeline. If maximum output buffer time was greater than the checkpoint interval, the pipeline would wait until all the outputs are flushed to process non-barrier inputs. Fixes: #6100 Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't pause inputs if a checkpoint has already started: once it has started, the checkpoint may be processing in a background thread but this shouldn't stop the pipeline from processing inputs.
Previously, only CheckpointBarrier inputs would be processed in this situation, preventing most inputs from being processed and stalling the pipeline. If maximum output buffer time was greater than the checkpoint interval, the pipeline would wait until all the outputs are flushed to process non-barrier inputs.
Fixes: #6100
Describe Manual Test Plan
We add a new test:
tests/platform/test_output_buffer_checkpoint.pyfor the buggy behavior. Just running this should validate that the bug no longer exists.Checklist