Skip to content

Redact sensitive request headers in logs #6218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
venkatamudili-fel wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

Redact sensitive request headers in logs #6218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion python/feldera/rest/_httprequests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,16 @@ def _is_502(exc: BaseException) -> bool:
return isinstance(exc, FelderaAPIError) and exc.status_code == 502


_SENSITIVE_HEADERS = {"authorization", "cookie", "proxy-authorization", "x-api-key"}


def _redact_headers(headers: dict) -> dict:
return {
key: "[REDACTED]" if key.lower() in _SENSITIVE_HEADERS else value
for key, value in headers.items()
}


class HttpRequests:
def __init__(self, config: Config) -> None:
self.config = config
Expand Down Expand Up @@ -194,7 +204,7 @@ def send_request(
"sending %s request to: %s with headers: %s, and params: %s",
http_method.__name__,
request_path,
str(self.headers),
_redact_headers(self.headers),
str(params),
)

Expand Down
Loading