[webconsole] Refine definition of 'paused' connector#6211
Conversation
There was a problem hiding this comment.
Yes, this will fix it. Please add a unit test (in MetricsTables.svelte.spec.ts) that checks that if there are two connectors - one end of input, one paused - the combined row shows "box-icon-paused" icon and not "box-icon-running". Claude will do it nicely
mythical-fred
left a comment
There was a problem hiding this comment.
George already flagged this -- please add a unit test in MetricsTables.svelte.spec.ts verifying that a connector with end_of_input === true and paused === false is not counted as running in the combined status row.
|
|
||
| {#snippet tableMultiConnectorCell(data: AggregatedInputEndpointMetrics, isExpanded: boolean)} | ||
| {@const runningCount = data.connectors.filter((c) => c.paused === false).length} | ||
| {@const runningCount = data.connectors.filter((c) => c.paused === false && c.metrics.end_of_input === false).length} |
There was a problem hiding this comment.
Behavior change without tests. The combined row icon now treats end-of-input connectors as non-running. This is testable with the existing accumulatePipelineMetrics test infrastructure in MetricsTables.svelte.spec.ts. A test case: two connectors -- one paused: false, end_of_input: true and one paused: false, end_of_input: false -- the combined icon should show running (not paused).
There was a problem hiding this comment.
It will take me a few hours to figure out how to write and run tests for the UI.
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
I hope this fixes #6206, but I don't have a complex enough pipeline handy to test