Skip to content

[connectors] configure storage for datafusion instances used by connectors #6170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swanandx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[connectors] configure storage for datafusion instances used by connectors #6170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions crates/adapterlib/src/errors/controller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,14 @@ pub enum ConfigError {
FtRequiresStorage,
FtRequiresFtInput,

/// `datafusion_memory_mb` was set to a value greater than or equal to
/// the pipeline's effective memory budget, which would leave no memory
/// for the DBSP circuit.
DatafusionMemoryExceedsBudget {
datafusion_memory_mb: u64,
max_rss_mb: u64,
},

InvalidLayout(LayoutError),
}

Expand Down Expand Up @@ -203,6 +211,9 @@ impl DbspDetailedError for ConfigError {
Self::FtRequiresFtInput => Cow::from("FtWithNonFtInput"),
Self::CyclicDependency { .. } => Cow::from("CyclicDependency"),
Self::EmptyStartAfter { .. } => Cow::from("EmptyStartAfter"),
Self::DatafusionMemoryExceedsBudget { .. } => {
Cow::from("DatafusionMemoryExceedsBudget")
}
Self::InvalidLayout(_) => Cow::from("LayoutError"),
}
}
Expand Down Expand Up @@ -417,6 +428,13 @@ impl Display for ConfigError {
f,
"Fault tolerance is configured, but it cannot be enabled because the pipeline has at least one non-fault-tolerant input adapter"
),
Self::DatafusionMemoryExceedsBudget {
datafusion_memory_mb,
max_rss_mb,
} => write!(
f,
"'datafusion_memory_mb' ({datafusion_memory_mb} MB) must be less than the pipeline's memory budget ({max_rss_mb} MB); the difference is the budget available to the DBSP circuit"
),
Self::InvalidLayout(e) => write!(f, "Multihost layout error: {e}"),
}
}
Expand Down
Loading
Loading