Conversation
mihaibudiu
approved these changes
Apr 28, 2026
| /// Returns the duration in seconds on success. This mirrors the grammar accepted by `delta-rs` | ||
| /// (`crates/core/src/table/config.rs::parse_interval`); we replicate it here to fail fast at | ||
| /// config-load time rather than only when the table is created. | ||
| fn parse_delta_interval(value: &str) -> Result<u64, String> { |
Contributor
There was a problem hiding this comment.
isn't their function public?
Member
Author
There was a problem hiding this comment.
expose log_retention_duration and enable_expired_log_cleanup for delta sinks so users can use them for configuring the table. Similar to what we do for checkpoint_interval Signed-off-by: Swanand Mulay <73115739+swanandx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expose log_retention_duration and enable_expired_log_cleanup for delta sinks so users can use them for configuring the table. Similar to what we do for checkpoint_interval
Fix #6027
Describe Manual Test Plan
Testing manually under diff scenarios, will update later.
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes
We add new fields to delta output config, shouldn't break existing things