Skip to content

[SQL] Do not serialize as JSON the contents of constant collections #6023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihaibudiu merged 1 commit into from
Apr 14, 2026
Merged

[SQL] Do not serialize as JSON the contents of constant collections #6023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql-to-dbsp-compiler/SQL-compiler/src/main/java/org/dbsp/util/RelJsonWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public RelJsonWriter(JsonBuilder jsonBuilder,
this.verbosity = verbosity;
}

final Set<String> highVerbosity = Set.of("exprs", "aggs", "condition");
final Set<String> highVerbosity = Set.of("exprs", "aggs", "condition", "tuples");

protected void explain_(RelNode rel, List<Pair<String, Object>> values) {
Map<String, Object> map = this.jsonBuilder.map();
Expand Down
13 changes: 13 additions & 0 deletions ...-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/MetadataTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2134,4 +2134,17 @@ public void testSilenceWarning() {
CREATE VIEW V AS SELECT x FROM T;""");
Assert.assertEquals(0, cc.compiler.messages.messages.size());
}

@Test
public void issue5896() throws IOException, SQLException {
String sql = "CREATE VIEW v AS select cot(0)";
File file = createInputScript(sql);
File json = this.createTempJsonFile();
CompilerMessages msg = CompilerMain.execute(
"--dataflow", json.getPath(), "--noRust", file.getPath());
Assert.assertEquals(0, msg.exitCode);
ObjectMapper mapper = Utilities.deterministicObjectMapper();
JsonNode parsed = mapper.readTree(json);
Assert.assertNotNull(parsed);
}
}