Conversation
- `rdkafka`: `0.37.0` -> `0.39.0` - `rdkafka-sys`: `4.8.0+2.3.0` -> `4.10.0+2.12.1` Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
mythical-fred
suggested changes
Apr 8, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Requesting changes: this PR bumps workspace/crate versions to 0.285.0 in addition to rdkafka, but the description/commit message only mention rdkafka. Please either drop the version bump or explicitly document it (and why) in the PR/commit message.
Contributor
Author
|
@mythical-fred No, you're hallucinating that. |
Contributor
Author
|
If the 0.285.0 workspace bump is intentional for this change, can you add a quick note to the PR description (or adjust the commit message)? Then I’m happy to clear the blocker. |
Contributor
Author
|
@mythical-fred Can you show me the lines that belong to the change you are referring to that needs to be documented? |
|
Sure — the version bumps are in Cargo.toml, not just rdkafka:
|
Member
|
Is fred looking at the same commit we are?! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rdkafka:0.37.0->0.39.0rdkafka-sys:4.8.0+2.3.0->4.10.0+2.12.1Relevant changelog: https://github.com/fede1024/rust-rdkafka/blob/master/changelog.md