-
Notifications
You must be signed in to change notification settings - Fork 111
Add checkpoint info to /stats API endpoint, add checkpoint info UI #6003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
035555a
10f0e4d
906003f
a76fc27
46cbe08
94542ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,10 +60,11 @@ use feldera_types::{ | |
| ExternalInputEndpointStatus, ExternalOutputEndpointMetrics, ExternalOutputEndpointStatus, | ||
| ShortEndpointConfig, | ||
| }, | ||
| checkpoint::CheckpointActivity, | ||
| config::{FtModel, PipelineConfig}, | ||
| coordination::Completion, | ||
| memory_pressure::MemoryPressure, | ||
| suspend::SuspendError, | ||
| suspend::{PermanentSuspendError, SuspendError}, | ||
| time_series::SampleStatistics, | ||
| transaction::CommitProgressSummary, | ||
| }; | ||
|
|
@@ -1196,6 +1197,8 @@ impl ControllerStatus { | |
| pub fn to_api_type( | ||
| &self, | ||
| suspend_error: Result<(), SuspendError>, | ||
| checkpoint_activity: CheckpointActivity, | ||
| permanent_checkpoint_errors: Option<Vec<PermanentSuspendError>>, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this type is awfully specific, is this the only type of error possible?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. PermanentSuspendError ? Yes, it covers a few possibilities. This is a type of errors that don't ever allow checkpointing the pipeline. |
||
| pipeline_complete: bool, | ||
| transaction_info: TransactionInfo, | ||
| memory_pressure: MemoryPressure, | ||
|
|
@@ -1330,6 +1333,8 @@ impl ControllerStatus { | |
| adapter_stats::ExternalControllerStatus { | ||
| global_metrics, | ||
| suspend_error: suspend_error.err(), | ||
| checkpoint_activity: Some(checkpoint_activity), | ||
| permanent_checkpoint_errors, | ||
| inputs, | ||
| outputs, | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not an expert in Rust concurrency, someone else will have to comment whether this is the right type to use here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a reasonable choice.