Add checkpoint info to /stats API endpoint, add checkpoint info UI#6003
Draft
Karakatiza666 wants to merge 2 commits intomainfrom
Draft
Add checkpoint info to /stats API endpoint, add checkpoint info UI#6003Karakatiza666 wants to merge 2 commits intomainfrom
Karakatiza666 wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: feldera-bot <feldera-bot@feldera.com>
mythical-fred
left a comment
There was a problem hiding this comment.
Two design questions, see inline.
|
|
||
| /// Converts epoch milliseconds to a `DateTime<Utc>`, falling back to | ||
| /// `Utc::now()` if the value is 0 or invalid. | ||
| fn epoch_ms_to_datetime(epoch_ms: i64) -> DateTime<Utc> { |
There was a problem hiding this comment.
If epoch_ms is 0/invalid, returning Utc::now() will make the UI show a fresh timestamp even when we don’t actually know the start time. Consider returning an Option (and omitting the field) or a sentinel so the UI can show "unknown" instead of a misleading "just now".
| let epoch_ms = self.checkpoint_started_epoch_ms(); | ||
| let started_at = epoch_ms_to_datetime(epoch_ms); | ||
| CheckpointActivity::InProgress { | ||
| sequence_number: 0, |
There was a problem hiding this comment.
sequence_number: 0 looks like a placeholder. If we can’t plumb the real seq here, consider making this field optional or dropping it from CheckpointActivity::InProgress for now to avoid exposing bogus data.
Contributor
|
please engage with anna for the UX |
Contributor
|
Some feedback on UI:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing:
Tested the UI using the mock API value simulator. Did not test the adapters and pipeline-manager changes