[connectors] Clock connector picks up clock resolution changes.#6001
Open
[connectors] Clock connector picks up clock resolution changes.#6001
Conversation
Enhance the `now` connector test to stop the pipeline, reconfigure clock resolution and restart the pipeline. This checks that the connector is correctly recreated after the restart. We don't have an easy way that the connector comes up with the updated config -- we currently don't expose that via the API. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
This fixes the following scenario: - Start a pipeline with a clock connector. - Checkpoint and stop the pipeline - Change clock resolution in pipeline config. - Restart the pipeline. The clock connector is initialized from the checkpoint, which contains connector config with the previous clock resolution value, instead of picking up the new config. The fix is to ignore the checkpointed connector and create a fresh connctor instead. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
Signed-off-by: feldera-bot <feldera-bot@feldera.com>
gz
approved these changes
Apr 7, 2026
blp
approved these changes
Apr 7, 2026
Member
blp
left a comment
There was a problem hiding this comment.
Seems reasonable.
I checked that replays don't depend on the configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following scenario:
The clock connector is initialized from the checkpoint, which contains connector config with the previous clock resolution value, instead of picking up the new config.
The fix is to ignore the checkpointed connector and create a fresh connector instead.