[web-console] Make pipelines table header sticky#5997
Merged
Karakatiza666 merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
c25b0ea to
b17f348
Compare
gz
approved these changes
Apr 6, 2026
mythical-fred
approved these changes
Apr 6, 2026
| </div> | ||
| <Datatable headless {table}> | ||
| <table class="md:px-6"> | ||
| <thead style="top: {controlsHeight}px; z-index: 1;"> |
There was a problem hiding this comment.
Is the header actually sticky? has a top offset but I don't see position: sticky / a sticky class here. If nothing sets it elsewhere, the header won't stick.
mythical-fred
suggested changes
Apr 6, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Missing tests for a web-console behavior change (sticky header/controls). Please add test coverage.
| {table} | ||
| class="w-20 py-1 pr-4 text-right xl:w-32" | ||
| field={(p) => p.connectors?.numErrors} | ||
| <div class="pipeline-table-wrapper bg-white-dark"> |
There was a problem hiding this comment.
This introduces sticky header/controls behavior. Per web-console rule, behavior changes need tests. Please add coverage (e2e/component) that the header/controls remain visible when scrolling the table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the table controls and header sticky:
Screencast from 2026-04-06 16-22-47.webm
The PR is basically a layout and style change.
Testing: manually tested the desktop-size and mobile-size behavior of pipelines page in a chrome-based browser and Firefox