Skip to content

[SQL] Add two missing visitor methods to CircuitDispatcher #5990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihaibudiu merged 1 commit into from
Apr 3, 2026
Merged

[SQL] Add two missing visitor methods to CircuitDispatcher #5990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...ompiler/src/main/java/org/dbsp/sqlCompiler/compiler/visitors/outer/CircuitDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package org.dbsp.sqlCompiler.compiler.visitors.outer;

import org.dbsp.sqlCompiler.circuit.DBSPDeclaration;
import org.dbsp.sqlCompiler.circuit.operator.DBSPOperator;
import org.dbsp.sqlCompiler.circuit.operator.DBSPOperatorWithError;
import org.dbsp.sqlCompiler.circuit.operator.DBSPSimpleOperator;
import org.dbsp.sqlCompiler.compiler.DBSPCompiler;
import org.dbsp.sqlCompiler.compiler.visitors.inner.InnerVisitor;
Expand Down Expand Up @@ -30,6 +32,20 @@ public void postorder(DBSPSimpleOperator operator) {
this.innerVisitor.setOperatorContext(null);
}

@Override
public void postorder(DBSPOperatorWithError operator) {
this.innerVisitor.setOperatorContext(operator);
operator.accept(this.innerVisitor);
this.innerVisitor.setOperatorContext(null);
}

@Override
public void postorder(DBSPOperator operator) {
this.innerVisitor.setOperatorContext(operator);
operator.accept(this.innerVisitor);
this.innerVisitor.setOperatorContext(null);
}

@Override
public void postorder(DBSPDeclaration decl) {
if (this.processDeclarations) {
Expand Down
18 changes: 18 additions & 0 deletions ...SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/simple/Regression2Tests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,4 +885,22 @@ public void issue5946() {
36 | 0.36""");
}

@Test
public void issue5989() {
this.getCCS("""
CREATE TABLE ee (
ab VARCHAR(110) NOT NULL PRIMARY KEY,
b VARCHAR(70) NOT NULL,
c SMALLINT NOT NULL,
d BIGINT NOT NULL PRIMARY KEY LATENESS 67::BIGINT,
e VARCHAR(60) NOT NULL ,
f VARCHAR(60) NOT NULL ,
g DECIMAL(38, 10),
h DECIMAL(38, 10),
i INT,
j INT,
k BOOLEAN,
l TIMESTAMP
) WITH ('materialized' = 'true');""");
}
}
Loading