Merged
Conversation
2326560 to
2f34ab5
Compare
| @@ -0,0 +1,40 @@ | |||
| import { describe, expect, it } from 'vitest' | |||
Contributor
There was a problem hiding this comment.
Please rename to string.spec.ts.
*.spec.ts are unit tests - pure functions, *.test.ts are integration tests - that have a Feldera instance available to them. I'll document this better in the future.
| const searchInput = page.getByTestId('input-pipeline-search') | ||
| await searchInput.fill('beta') | ||
|
|
||
| await expect(page.getByRole('link', { name: `${PREFIX}-beta` })).toBeVisible() |
Contributor
There was a problem hiding this comment.
Refactor all page.getByRole('link', ... with
page.getByTestId(`box-row-${PREFIX}-...`)
, and add an appropriate data-testid="box-row-{PREFIX}-{pipeline.name}" attribute to the corresponding <td> tag in Table.svelte
Using getByTestId instead of getByRole and others makes for more robust tests, unless the specific attribute (e.g. role) or text needs to be tested.
15881a6 to
8cea24d
Compare
Added a search feature to the UI to filter pipelines by name Signed-off-by: Anand Raman <anand.raman@feldera.com> updated tests
7b1f1d3 to
c25b0ea
Compare
Contributor
|
LGTM! |
c25b0ea to
3121825
Compare
Karakatiza666
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Manual Test Plan
Added search feature for pipelines. Closes #5972.
Example:
Example 600 x 417
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes