Skip to content

[web-console] Fix failing to display the connector errors … #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Karakatiza666 merged 3 commits into from
Apr 5, 2026
Merged

[web-console] Fix failing to display the connector errors … #5933

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef4df3e
[web-console] Fix failing to display the connector errors if the tabl…
Karakatiza666 Mar 25, 2026
b28f581
[web-console] Integration tests for retrieving connector errors
Karakatiza666 Mar 25, 2026
59c6880
[web-console] Integration tests for retrieving connector errors
Karakatiza666 Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[web-console] Fix failing to display the connector errors if the tabl… 
…e or connector name includes URL-unsafe characters (e.g. '.')

Remove unnecessary conversion of URL-safe pipeline_name-s

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
  • Loading branch information
@Karakatiza666
Karakatiza666 committed Apr 4, 2026
commit ef4df3e7d760dffbe3caad6240d166d8858481c6
22 changes: 11 additions & 11 deletions js-packages/web-console/src/lib/services/pipelineManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ export const getExtendedPipeline = async (
) => {
return mapResponse(
_getPipeline({
path: { pipeline_name: encodeURIComponent(pipeline_name) },
path: { pipeline_name },
...options
}),
toExtendedPipeline,
Expand Down Expand Up @@ -398,7 +398,7 @@ export const putPipeline = async (
await mapResponse(
_putPipeline({
body: newPipeline,
path: { pipeline_name: encodeURIComponent(pipeline_name) },
path: { pipeline_name },
...options
}),
(v) => v
Expand All @@ -412,7 +412,7 @@ export const patchPipeline = async (
) => {
return mapResponse(
_patchPipeline({
path: { pipeline_name: encodeURIComponent(pipeline_name) },
path: { pipeline_name },
body: fromPipeline(pipeline),
...options
}),
Expand All @@ -433,7 +433,7 @@ export const getPipelines = async (options?: FetchOptions): Promise<PipelineThum
export const getPipelineStatus = async (pipeline_name: string, options?: FetchOptions) => {
return mapResponse(
_getPipeline({
path: { pipeline_name: encodeURIComponent(pipeline_name) },
path: { pipeline_name },
query: { selector: 'status' },
...options
}),
Expand All @@ -450,7 +450,7 @@ export const getPipelineStatus = async (pipeline_name: string, options?: FetchOp
export const getPipelineStats = async (pipeline_name: string, options?: FetchOptions) => {
return mapResponse(
_getPipelineStats({
path: { pipeline_name: encodeURIComponent(pipeline_name) },
path: { pipeline_name },
...options
}),
(status) => ({
Expand All @@ -477,7 +477,7 @@ export const getInputConnectorStatus = (
) =>
mapResponse(
_getPipelineInputConnectorStatus({
path: { pipeline_name, table_name, connector_name },
path: { pipeline_name, table_name: encodeURIComponent(table_name), connector_name: encodeURIComponent(connector_name) },
...options
}),
(v) => v
Expand All @@ -491,7 +491,7 @@ export const getOutputConnectorStatus = (
) =>
mapResponse(
_getPipelineOutputConnectorStatus({
path: { pipeline_name, view_name, connector_name },
path: { pipeline_name, view_name: encodeURIComponent(view_name), connector_name: encodeURIComponent(connector_name) },
...options
}),
(v) => v
Expand Down Expand Up @@ -550,7 +550,7 @@ export const postApiKey = (name: string, options?: FetchOptions) =>

export const deleteApiKey = (name: string, options?: FetchOptions) =>
mapResponse(
_deleteApiKey({ path: { api_key_name: name }, ...options }),
_deleteApiKey({ path: { api_key_name: encodeURIComponent(name) }, ...options }),
(v) => v,
() => {
throw new Error(`Failed to delete ${name} API key`)
Expand Down Expand Up @@ -578,7 +578,7 @@ export const getClusterEvent = (eventId: string) =>
const getSamplyProfileStream = (pipelineName: string, latest: boolean) => {
const result = streamingFetch(
getAuthenticatedFetch(),
`${felderaEndpoint}/v0/pipelines/${encodeURIComponent(pipelineName)}/samply_profile${latest ? '?latest=true' : ''}`,
`${felderaEndpoint}/v0/pipelines/${pipelineName}/samply_profile${latest ? '?latest=true' : ''}`,
{
method: 'GET'
}
Expand Down Expand Up @@ -929,7 +929,7 @@ export const relationIngress = async (
options?: FetchOptions
) => {
return httpInput({
path: { pipeline_name: pipelineName, table_name: relationName },
path: { pipeline_name: pipelineName, table_name: encodeURIComponent(relationName) },
parseAs: 'text', // Response is empty, so no need to parse it as JSON
query: { format: 'json', array: true, update_format: 'insert_delete', force: !!force },
body: data as any,
Expand Down Expand Up @@ -967,5 +967,5 @@ export const getPipelineSupportBundleUrl = (
for (const [key, value] of Object.entries(options)) {
query.append(key, String(value))
}
return `${felderaEndpoint}/v0/pipelines/${encodeURIComponent(pipelineName)}/support_bundle?${query.toString()}`
return `${felderaEndpoint}/v0/pipelines/${pipelineName}/support_bundle?${query.toString()}`
}