addressed remaining comments

…oting rule

Signed-off-by: feldera-bot <feldera-bot@feldera.com>

…ing and skills

Signed-off-by: feldera-bot <feldera-bot@feldera.com>

Signed-off-by: feldera-bot <feldera-bot@feldera.com>

- Added --model CLI option to translate, translate-file, and example commands
- Model and compiler path now read exclusively from .env / CLI flags
- Removed OpenAI provider support (untested)
- Removed hardcoded default compiler path
- Updated README for consistency

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- llm.py: wrap system prompt in cache_control ephemeral block to enable
  Anthropic prompt caching; add retry with exponential backoff on rate limits
- translator.py: omit examples on first translation attempt (skills only)
  to reduce token usage and latency (~20s → ~4s for simple queries)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- STRING/TEXT type mapping: STRING→VARCHAR, TEXT→VARCHAR
- Remove duplicate HEX/UNHEX from Hashing section
- Remove CAST(INTERVAL SECOND AS DECIMAL) from Unsupported (contradicted Supported section)
- Window: unify ROWS/RANGE BETWEEN into one Unsupported entry
- split(str,delim,limit): clarify 2-arg form is supported
- LN/LOG10: "runtime error" → "drops the row (WorkerPanic)" for negative input
- TIMESTAMP_NTZ: clarify "replace with TIMESTAMP in DDL"
- FIRST_VALUE/LAST_VALUE notes consistent with Window unsupported section
- Scalar subquery rule: fix incorrect "subquery with FROM → mark unsupported"
- Remove unexplained CREATE TYPE + jsonstring_as_ hint
- trunc(d,'Q'): move to Unsupported (DATE_TRUNC QUARTER fails at runtime)
- make_timestamp: move to Rewritable with PARSE_TIMESTAMP rewrite
- from_unixtime: use TIMESTAMPADD directly (consistent with to_timestamp)
- encode/decode: remove misleading "IS rewritable as CASE WHEN" note
- width_bucket: remove stray extra column
- SIGN: remove misleading "Input/output: DECIMAL" note
- date_format: handle TIMESTAMP input via CAST to DATE
- log(base,x): add examples to reinforce arg swap rule
- [GBD-ARRAY-ORDER]: new GBD entry; annotate ARRAY_UNION/ARRAY_EXCEPT
- Bitwise scalar operators moved to Unsupported section

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Signed-off-by: feldera-bot <feldera-bot@feldera.com>

- Add ground truth note: all signatures from spark.apache.org/docs/latest/api/sql/index.html
- Fix unix_millis/unix_micros: take timestamp arg (not no-arg current-time)
- Fix pmod: unified formula MOD(MOD(a,ABS(b))+ABS(b),ABS(b)) for all divisor signs
- Move try_divide/try_add/try_subtract/try_multiply to unsupported (semantic mismatch)
- Move map_entries to unsupported (returns array of structs, no Feldera equivalent)
- Fix from_unixtime: note STRING vs TIMESTAMP type difference, mark fmt-arg as unsupported
- Fix posexplode: subtract 1 from ORDINALITY (Spark 0-based, SQL 1-based)
- Add translate warning: REGEXP_REPLACE treats chars as regex patterns
- Fix lpad/rpad: document optional pad arg (defaults to space)
- Fix months_between: add roundOff note, precise fractional example
- Fix trunc WEEK: move to unsupported (same Sunday/Monday mismatch as date_trunc WEEK)
- Move try_* from String to Math in unsupported section
- Add trunc YYYY/MM/MON aliases, to_date using PARSE_TIMESTAMP

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…vial entries

- Fix json_extraction: lateral alias not supported in Feldera; repeat PARSE_JSON per field
- Fix datediff: use correct DATEDIFF(DAY, start, end) instead of TIMESTAMPDIFF
- Replace null_safe_equality with LOG argument order reversal (critical gotcha)
- Replace nvl_coalesce with LPAD/RPAD rewrite (no native support in Feldera)
- Improve array_map_functions: add element_at(map,key) → map[key], CARDINALITY NULL note
- Add explode_unnest: LATERAL VIEW explode/posexplode/inline → UNNEST patterns
- Add json_extraction: get_json_object → PARSE_JSON + bracket syntax, CTE for GROUP BY
- Remove array_lambda (unsupported-only, no rewrite value)
- Remove row_number_topk (trivial CREATE VIEW wrapper, no translation needed)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…d, to_date, date_format

- Remove trunc(d,'Q') from supported section — DATE_TRUNC(QUARTER) fails at
  runtime in Feldera (date_trunc_quarter_DateN missing); unsupported entry at
  line 716 was already correct
- Fix contains(binary,...) — POSITION rewrite works for binary args; only
  boolean args are truly unsupported
- Fix pmod formula to CASE WHEN MOD(a,b)<0 AND b>0 THEN MOD(a,b)+b ELSE
  MOD(a,b) END (empirically verified against all sign combinations)
- Fix to_date: use PARSE_DATE not PARSE_TIMESTAMP (panics on date-only strings)
- Fix date_format: FORMAT_DATE truncates time; use CONCAT+EXTRACT for time
  components; FORMAT_TIMESTAMP does not exist; LPAD does not work here
- Fix JSON lateral alias note: Feldera does NOT support lateral aliases

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- nvl_coalesce.md → lpad_rpad.md (contains LPAD/RPAD rewrite)
- null_safe_equality.md → log_arg_order.md (contains LOG arg order reversal)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- left_semi_join: add CREATE TABLE schemas, fix WHERE→ON clause placement
- to_date_date_format (new): PARSE_DATE vs PARSE_TIMESTAMP, FORMAT_DATE+EXTRACT
  pattern for time components, FORMAT_TIMESTAMP nonexistence
- window_functions (new): ROW_NUMBER TopK, LAG/LEAD, partition SUM; notes on
  ROWS/RANGE frames unsupported and TopK outer-WHERE requirement
- pmod_try_arithmetic (new): pmod CASE WHEN rewrite, try_divide NULL approximation,
  try_subtract direct translation with overflow warning

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

… examples

- windows_query: remove ROWS BETWEEN frame (unsupported in Feldera)
- aggregations_query: replace PERCENTILE_APPROX with STDDEV (no Feldera equivalent)
- json_combined: replace $.items[0] array path with scalar path (array paths unsupported)
- topk_combined: replace Feldera 3-arg DATEDIFF with Spark 2-arg datediff (Spark input)
- Add dates_combined: to_date / date_format Spark input demo
- Add arithmetic_combined: pmod / try_divide / try_subtract Spark input demo

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…eatures

- aggregations: remove COLLECT_LIST (unsupported), STDDEV → SUM
- arithmetic: replace try_divide/try_subtract with NULLIF division and direct subtraction

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…eger inputs

- AVG(INT/BIGINT/SMALLINT/TINYINT) is safely rewritable via CAST to DOUBLE
- Remove known_unsupported entries for AVG(INT) tests now covered by the rewrite
  (cast_to_date_003, select_no_from_002, grouping_sets_002, cube_agg_002, null-handling_015)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Commands are now under a 'spark' subgroup to support future dialects.
  felderize spark translate
  felderize spark translate-file
  felderize spark example

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

skills are dialect-agnostic rules; placing at data/skills/ makes the
directory structure cleaner for future dialects alongside spark/.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…i-join note

- json_extraction.md: use lateral alias pattern (PARSE_JSON once, reuse)
- spark_skills.md: Feldera supports lateral aliases, update JSON notes
- array_map_functions.md: use COALESCE(CARDINALITY(tags), -1) for exact NULL match
- spark_skills.md: update size() → COALESCE(CARDINALITY, -1) rewrite
- left_semi_join.md: clarify note about right-table filter placement
- README.md: update commands to felderize spark subcommand

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ee79db25981c099d' of github.com:feldera/feldera into felderize

…ries

- Move rewrite-requiring functions from Direct equivalents to Rewritable patterns:
  LTRIM/RTRIM, NVL/ZEROIFNULL/NULLIFZERO, any→bool_or, collect_list/collect_set, DAY→DAYOFMONTH
- Move direct equivalents out of Rewritable patterns:
  GROUPING SETS/ROLLUP/CUBE/grouping_id, JOIN USING/NATURAL JOIN, sec/csc/cot
- Fix Higher-order array functions table: add missing header, move exists→ARRAY_EXISTS to Rewritable
- Remove RANGE BETWEEN from Unsupported (it is supported); move TIMESTAMP_NTZ to DDL Rewrites
- Add missing entries: IF(), INSTR(), isnull()/isnotnull()

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Skills corrections:
- GBD-FLOAT-GROUP: clarify it affects ORDER BY (not GROUP BY) on special float values
- BINARY→VARBINARY: add type mapping; x'...' hex literals work in both engines
- every/bool_and/bool_or: add note that window functions with ORDER BY BOOLEAN unsupported (#457)
- SPLIT_PART: remove (same in both engines, no special handling needed)
- get_json_object: document that CAST(VARIANT AS VARCHAR) returns NULL for numbers/booleans
- collect_list/ARRAY_AGG: tag with GBD-ARRAY-ORDER; add ORDER BY recommendation
- positive()/negative(): simplify to x/-x (Feldera auto-casts string args)
- hex(x): document UPPER(TO_HEX()) required; TO_HEX accepts VARBINARY only
- split(str, regex): document Feldera SPLIT only supports literal delimiters
- PARSE_JSON lateral alias: reframe as translation warning (don't expose v as view column)
- GROUPING SETS + HAVING: add concrete example of alias collision bug
- VALUES implicit column names: improve example to clearly show wrong vs correct

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Extract long inline notes into tagged behavioral difference blocks
  (GBD-JSON-CAST, GBD-OUTER-EXPLODE, GBD-PIVOT-NULL, GBD-TIMEZONE,
   GBD-MONTHS-BETWEEN, GBD-SAFE-CAST)
- Add emoji heading markers (⚠️ 🔄 📌 📝) throughout Rewritable patterns
- Move LOCATE 3-arg and translate() examples to Notes blocks
- Move log() arg-order warning to Notes block
- Restructure UNNEST details, DATE_ADD, named_struct with proper subsections
- Restructure SQL Syntax differences subsections with translation rules and examples
- Clean up Unsupported table: merge duplicate rows, fix malformed split row,
  reference GBD-NONDETERMINISTIC for uuid()

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Fix GROUPING SETS + HAVING example: Spark returns 2 rows not 1
  (verified by having_006 test: feldera=0, spark=2)
- Add split_part with regex special char delimiters to Unsupported
  (verified by string-functions_024: SPLIT_PART('11.12.13', '.', 2)
   returns '' in Feldera vs '12' in Spark — filed as Feldera bug)
- Expand GBD-ARRAY-ORDER to include ARRAY_INTERSECT, MAP_KEYS, MAP_VALUES,
  collect_set (verified by test failures in known_unsupported.yaml)
- All 28 validate_skills failures confirmed in known_unsupported.yaml

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…eric AS TIMESTAMP) semantics; update README model and ANTHROPIC_BASE_URL

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Signed-off-by: feldera-bot <feldera-bot@feldera.com>