[DBSP] Support recursive circuits that have up to 14 back-edges (up from 12)#5194
Merged
Conversation
…rom 12) Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases the maximum number of back-edges supported in recursive circuits from 12 to 14 by updating the impl_for_tuples macro parameter across multiple files.
- Increased tuple implementation limit from 12 to 14 in recursive circuit operators
- Updated corresponding implementations in non-incremental operators and num_entries trait
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/dbsp/src/operator/recursive.rs | Updated impl_for_tuples from 12 to 14 for RecursiveStreams |
| crates/dbsp/src/operator/non_incremental.rs | Updated impl_for_tuples from 12 to 14 for NonIncrementalInputStreams |
| crates/dbsp/src/operator/dynamic/recursive.rs | Updated impl_for_tuples from 12 to 14 for dynamic RecursiveStreams |
| crates/dbsp/src/num_entries.rs | Updated impl_for_tuples from 12 to 14 for NumEntries trait |
Contributor
Author
|
This limitation is not documented anywhere. |
mihaibudiu
enabled auto-merge
November 28, 2025 18:18
ryzhyk
approved these changes
Nov 30, 2025
ryzhyk
left a comment
Contributor
There was a problem hiding this comment.
Any reason not to push it a bit farther (say, 24?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5193