[SQL] GC output of input_map_with_waterline#4631
Merged
Merged
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses garbage collection for the output of input_map_with_waterline operators as mentioned in issue #2669, while also fixing numerous typos and removing unused imports throughout the SQL compiler codebase.
Key changes include:
- Added garbage collection support for
DBSPInputMapWithWaterlineOperatorby integratingDBSPIntegrateTraceRetainValuesOperator - Extensive cleanup of unused imports across Java files
- Fixed grammar, spelling, and formatting issues in comments and documentation
- Improved code style with better variable naming and enhanced for-loop usage
Reviewed Changes
Copilot reviewed 59 out of 59 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sql-to-dbsp-compiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/compiler/visitors/outer/monotonicity/InsertLimiters.java | Added garbage collection logic for input_map_with_waterline by creating DBSPIntegrateTraceRetainValuesOperator |
| sql-to-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/CatalogTests.java | Added test to verify garbage collection behavior for InputMapWithWaterline |
| sql-to-dbsp-compiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/compiler/visitors/outer/StrayGC.java | Added exception for DBSPInputMapWithWaterlineOperator in GC checking logic |
| Multiple files | Removed unused imports throughout the codebase |
| Multiple files | Fixed typos, grammar issues, and improved comment formatting |
Contributor
Author
|
Before: |
input_map_with_waterline
ryzhyk
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2669
This PR also fixes a bunch of typos in comments