Switch ad-hoc queries to arrow_ipc format#4240
Conversation
56b7606 to
9c0a916
Compare
|
It doesn't look like it answers queries (I tried fraud-detection), revision 9c0a916 |
|
I think you encountered this one: #4239 |
9c0a916 to
166c097
Compare
gz
left a comment
There was a problem hiding this comment.
lgtm make sure to do
some testing before merging (different pipelines with different types (variant map etc.) and queries)
|
@Karakatiza666 can we merge this? |
|
Haven't had the chance to do a few tests with complex types, hopefully tomorrow |
166c097 to
94e2e00
Compare
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
94e2e00 to
726dedf
Compare
|
Blocked by #4287 |
mythical-fred
left a comment
There was a problem hiding this comment.
Web-console behavioral changes without tests. Blocked by #4287 per author — but tests are also needed before this lands.
| import BigNumber from 'bignumber.js' | ||
| import Dayjs from 'dayjs' | ||
|
|
||
| const arrowIpcValueToJS = <T extends DataType<Type, any>>(arrowType: Field<T>, value: any) => { |
There was a problem hiding this comment.
New Arrow IPC value conversion logic covers a lot of type cases (int64, timestamps, structs, maps, lists). This is exactly the kind of logic that deserves unit tests — each type case can go wrong independently. Per Gerd's directive (2026-03-04): behavioral changes require tests. Setup: npm install -D vitest @testing-library/svelte jsdom. The pure conversion functions here are ideal for unit testing without any DOM or component setup.
I will squash commits before merging.
Part of #4219: Deprecate the JSON format for ad-hoc queries