[SQL] Simplify the structure of the simple end to end tests#1065
Merged
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
lalithsuresh
approved these changes
Nov 23, 2023
|
|
||
| @Test @Override | ||
| public void constantFoldTest() { | ||
| String query = "SELECT 1 + 2"; |
Contributor
There was a problem hiding this comment.
Very nice that you got rid of all of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this a user-visible change (yes/no): no
Exactly the same tests are being run as previously, but there is less bug-prone code duplication.
This essentially moves some code from NaiveIncrementalTests to EndToEndTests