Add an async context data test for @fedify/express by Jae-Hyuk-Jang · Pull Request #985 · fedify-dev/fedify

Jae-Hyuk-Jang · 2026-08-07T12:17:15Z

Summary

integrateFederation()'s contextDataFactory may return a plain value or a Promise, but only the synchronous path had test coverage.
This adds a regression test for the async path, verifying the middleware waits for the factory to resolve and passes the resolved value to federation.fetch().

Also adds the missing test script (package.json) and test task (deno.json) for @fedify/express so the suite actually runs under mise run test:node / test-each.

Fixes #855

Test plan

mise run check-each express
deno test --allow-all (packages/express)
node --experimental-transform-types --test (packages/express)

AI disclosure

This change was written with assistance from Claude Code (claude-sonnet-5), reviewed and verified by me.

integrateFederation() accepts a contextDataFactory that may return either a plain value or a Promise, but only the synchronous path was covered. Add a test that verifies the middleware waits for an async factory to resolve and passes the resolved value to federation.fetch(). Also wire up the test script/task in package.json and deno.json so mise run test:node and test-each actually run it. Changelog: none Assisted-by: Claude Code:claude-sonnet-5

netlify · 2026-08-07T12:17:24Z

✅ Deploy Preview for fedify-json-schema canceled.

Name	Link
🔨 Latest commit	`cd288b2`
🔍 Latest deploy log	https://app.netlify.com/projects/fedify-json-schema/deploys/6a7814220ec6a5000802330b

coderabbitai · 2026-08-07T12:20:15Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 50d84419-ee79-4d26-ae0c-c021e2d334d9

📥 Commits

Reviewing files that changed from the base of the PR and between 9e6c38a and cd288b2.

📒 Files selected for processing (1)

packages/express/src/index.test.ts

💤 Files with no reviewable changes (1)

packages/express/src/index.test.ts

📝 Walkthrough

Walkthrough

The Express package adds Deno, Node, and Bun test commands. New middleware tests verify that integrateFederation() awaits asynchronous context data, passes the resolved value to federation.fetch(), writes the response, and does not call next().

Changes

Express async context test

Layer / File(s)	Summary
Async context middleware validation `packages/express/src/index.test.ts`, `packages/express/deno.json`, `packages/express/package.json`	The test adds mock request and response helpers, verifies asynchronous context resolution and federation fetch input, captures the response, and confirms that `next()` is not called. Deno, Node, and Bun commands run the package test suite.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Add a context data test for @fedify/elysia #852 — Adds a similar asynchronous contextDataFactory propagation test for another framework integration.

Possibly related PRs

fedify-dev/fedify#988 — Adds a comparable asynchronous context-data integration test for the Fresh adapter.

Suggested labels: component/integration

Suggested reviewers: dahlia

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the added asynchronous context data test for `@fedify/express`.
Description check	✅ Passed	The description explains the async regression test, added test commands, validation steps, and linked issue.
Linked Issues check	✅ Passed	The PR adds the required async contextDataFactory test and verifies resolution before federation.fetch() receives the value [`#855`].
Out of Scope Changes check	✅ Passed	The changes are limited to the requested regression test and package test configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/express/src/index.test.ts`:
- Around line 65-88: Update the async contextDataFactory test to use a deferred
promise and track federation.fetch invocation; assert fetch remains uncalled
before resolving the promise, then resolve it and verify the existing response
and middleware behavior after completion.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 67407354-e127-4371-939c-d560137a9e46

📥 Commits

Reviewing files that changed from the base of the PR and between 15ad151 and 64bcda0.

📒 Files selected for processing (3)

packages/express/deno.json
packages/express/package.json
packages/express/src/index.test.ts

The previous test only checked the resolved value, not that federation.fetch() stays uncalled until the async contextDataFactory promise resolves. Use a deferred promise to assert the ordering directly, per CodeRabbit's review on fedify-dev#985. Changelog: none Assisted-by: Claude Code:claude-sonnet-5

sij411

Since integrateFederation() only assigns send, json, and removeHeader and never calls their existing implementations, could these methods be omitted from the initial response mock?

2chanhaeng

Thanks for your contribution! Please check my comment.

The package had a Node test script but no Bun equivalent, so the suite never ran under Bun. Mirror the elysia package's pattern. Changelog: none Assisted-by: Claude Code:claude-sonnet-5

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/express/package.json`:
- Line 62: Add an engines.node declaration in packages/express/package.json
covering the Node versions that support --experimental-transform-types, or
replace that flag with a test command compatible with the package’s declared
Node support baseline. Keep the test script’s behavior unchanged for supported
runtimes.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 06c7d757-01e1-434f-a281-caebe31bfec5

📥 Commits

Reviewing files that changed from the base of the PR and between a59ed13 and 9e6c38a.

📒 Files selected for processing (1)

packages/express/package.json

integrateFederation() only overwrites send, json, and removeHeader with no-ops; it never calls their existing implementations, so the mock response doesn't need them. Changelog: none Assisted-by: Claude Code:claude-sonnet-5

Jae-Hyuk-Jang · 2026-08-09T05:46:42Z

Since integrateFederation() only assigns send, json, and removeHeader and never calls their existing implementations, could these methods be omitted from the initial response mock?

Good catch, removed them — thanks!

codecov · 2026-08-12T05:05:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Jae-Hyuk-Jang requested review from 2chanhaeng and dahlia as code owners August 7, 2026 12:17

coderabbitai Bot reviewed Aug 7, 2026

View reviewed changes

Comment thread packages/express/src/index.test.ts

sij411 reviewed Aug 7, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Aug 8, 2026

Add integration tests for packages/fresh/src/mod.ts (#863, #864, #865) #988

Open

2chanhaeng requested changes Aug 8, 2026

View reviewed changes

Comment thread packages/express/package.json Outdated

Add the test:bun script for @fedify/express

9e6c38a

The package had a Node test script but no Bun equivalent, so the suite never ran under Bun. Mirror the elysia package's pattern. Changelog: none Assisted-by: Claude Code:claude-sonnet-5

coderabbitai Bot reviewed Aug 9, 2026

View reviewed changes

Comment thread packages/express/package.json

Drop unused response mock methods

cd288b2

integrateFederation() only overwrites send, json, and removeHeader with no-ops; it never calls their existing implementations, so the mock response doesn't need them. Changelog: none Assisted-by: Claude Code:claude-sonnet-5

2chanhaeng approved these changes Aug 12, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

Add an async context data test for @fedify/express - #985

Add an async context data test for @fedify/express#985
Jae-Hyuk-Jang wants to merge 4 commits into
fedify-dev:mainfrom
Jae-Hyuk-Jang:test/express-async-context-data

Jae-Hyuk-Jang commented Aug 7, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Aug 7, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 7, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

sij411 left a comment

Uh oh!

2chanhaeng left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Jae-Hyuk-Jang commented Aug 9, 2026

Uh oh!

codecov Bot commented Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Jae-Hyuk-Jang commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

AI disclosure

Uh oh!

netlify Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fedify-json-schema canceled.

Uh oh!

coderabbitai Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sij411 left a comment

Choose a reason for hiding this comment

Uh oh!

2chanhaeng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jae-Hyuk-Jang commented Aug 9, 2026

Uh oh!

codecov Bot commented Aug 12, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jae-Hyuk-Jang commented Aug 7, 2026 •

edited

Loading

netlify Bot commented Aug 7, 2026 •

edited

Loading

coderabbitai Bot commented Aug 7, 2026 •

edited

Loading