Skip to content

Add actors table and actor GraphQL API - #47

Open
2chanhaeng wants to merge 11 commits into
fedify-dev:mainfrom
2chanhaeng:create-actor
Open

Add actors table and actor GraphQL API#47
2chanhaeng wants to merge 11 commits into
fedify-dev:mainfrom
2chanhaeng:create-actor

Conversation

@2chanhaeng

Copy link
Copy Markdown
Member

Resolves #6.
Add actors table and actor GraphQL API to create and reads.

To merge this PR, #44 must be preceded.

Assisted-by: Codex:gpt-5-6-sol to generate test.

Prompt:
DB 스키마에서 `instance` 를 Local/Remote 로 분리하고 API 를 수정하면서 기존 스키마/API 에 맞춰놨던 일부 테스트가 문제 되고 있습니다. [instance.test.ts](packages/graphql/src/instance.test.ts) 파일의 20419ce 커밋 변경 사항을 참고해서 문제되는 파일들의 코드를 직접 수정하세요. 문제되는 파일들은 `mise check`, `mise test` 로 찾을 수 있습니다.
추가적으로 리모트 인스턴스를 위한 테스트도 추가하세요. 너무 복잡한 테스트 말고, 생성, host 유일성 체크 정도만 추가하세요.

Assisted-by: Codex:gpt-5-6-sol
@2chanhaeng
2chanhaeng requested review from dahlia, dodok8 and sij411 August 4, 2026 05:14
@2chanhaeng 2chanhaeng self-assigned this Aug 4, 2026
Prompts:
Actor 를 위한 GraphQL 빌더를 추가했습니다. @packages/graphql/src/actor.test.ts 에 이를 위한 테스트를 생성해주세요. 파일 추가 직후 `mise run fmt` 로 라이선스를 추가하세요. 최소한 다음과 같은 테스트가 필요합니다.
- 액터 생성
- 로컬 액터 조회
- 리모트 액터 조회

Assisted-by: Codex:gpt-5-6-sol
@sij411

sij411 commented Aug 14, 2026

Copy link
Copy Markdown
Member

I have some comments related to actor schema. I see only followee/follower counters not actual follow relationship among actors. I don't think remoteActors.followeeUrl is the right method to fetch remote actor's following/followers. It's 'remote' that means their server status is outside our controls. So we should think about storing follow relationship i think. Also as far as i know, 'following' is more common than the word 'followee' in other ActivityPub implementations.

@2chanhaeng

Copy link
Copy Markdown
Member Author

I have some comments related to actor schema. I see only followee/follower counters not actual follow relationship among actors. I don't think remoteActors.followeeUrl is the right method to fetch remote actor's following/followers. It's 'remote' that means their server status is outside our controls. So we should think about storing follow relationship i think. Also as far as i know, 'following' is more common than the word 'followee' in other ActivityPub implementations.

I haven't fully implemented the follow-related features yet since they weren't part of the current goal. I've kept the terminology as consistent as possible with the Hackers' Pub codebase. Personally, I also prefer the term "followee" because it provides a clear contrast to "follower."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GraphQL API for creating actors

3 participants