Skip to content

Update registry start script to support REACT_APP_ENABLE_RBAC==false cases #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoyongzhu merged 1 commit into from
Jan 12, 2023
Merged

Update registry start script to support REACT_APP_ENABLE_RBAC==false cases #954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions deploy/start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,8 @@ nginx
# Start API app
LISTENING_PORT="8000"

if [ "x$REACT_APP_ENABLE_RBAC" == "x" ]; then
echo "RBAC flag not configured, only launch registry app"
if [ "x$PURVIEW_NAME" == "x" ]; then
echo "Purview flag is not configured, run SQL registry"
cd sql-registry
uvicorn main:app --host 0.0.0.0 --port $LISTENING_PORT
else
echo "Purview flag is configured, run Purview registry"
cd purview-registry
uvicorn main:app --host 0.0.0.0 --port $LISTENING_PORT
fi
else
echo "RBAC flag configured, launch both rbac and reigstry apps"
if [ "$REACT_APP_ENABLE_RBAC" == "true" ]; then
Comment thread
xiaoyongzhu marked this conversation as resolved.
echo "RBAC flag configured and set to true, launch both rbac and reigstry apps"
if [ "x$PURVIEW_NAME" == "x" ]; then
echo "Purview flag is not configured, run SQL registry"
cd sql-registry
Expand All @@ -65,4 +54,15 @@ else
export RBAC_API_AUDIENCE="${REACT_APP_AZURE_CLIENT_ID}"
export RBAC_CONNECTION_STR="${CONNECTION_STR}"
uvicorn main:app --host 0.0.0.0 --port $LISTENING_PORT
else
echo "RBAC flag not configured or not equal to true, only launch registry app"
if [ "x$PURVIEW_NAME" == "x" ]; then
echo "Purview flag is not configured, run SQL registry"
cd sql-registry
uvicorn main:app --host 0.0.0.0 --port $LISTENING_PORT
else
echo "Purview flag is configured, run Purview registry"
cd purview-registry
uvicorn main:app --host 0.0.0.0 --port $LISTENING_PORT
fi
fi