Skip to content

Fix direct purview client missing transformation #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yuqing-cat merged 1 commit into from
Oct 13, 2022
Merged

Fix direct purview client missing transformation #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions feathr_project/feathr/registry/_feature_registry_purview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,11 +1368,11 @@ def _get_transformation_from_dict(self, input: Dict) -> FeatureType:
if 'transformExpr' in input:
# it's ExpressionTransformation
return ExpressionTransformation(input['transformExpr'])
elif 'def_expr' in input:
agg_expr=input['def_expr'] if 'def_expr' in input else None
agg_func=input['agg_func']if 'agg_func' in input else None
elif 'def_expr' in input or 'defExpr' in input:
Comment thread
Yuqing-cat marked this conversation as resolved.
agg_expr=input['def_expr'] if 'def_expr' in input else (input['defExpr'] if 'defExpr' in input else None)
agg_func=input['agg_func']if 'agg_func' in input else (input['aggFunc'] if 'aggFunc' in input else None)
window=input['window']if 'window' in input else None
group_by=input['group_by']if 'group_by' in input else None
group_by=input['group_by']if 'group_by' in input else (input['groupBy'] if 'groupBy' in input else None)
filter=input['filter']if 'filter' in input else None
limit=input['limit']if 'limit' in input else None
return WindowAggTransformation(agg_expr, agg_func, window, group_by, filter, limit)
Expand Down