Skip to content

Split feature details into three columns #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blrchen merged 1 commit into from
Jul 20, 2022
Merged

Split feature details into three columns #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions ui/src/pages/feature/featureDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,13 @@ function FeatureKey(props: { feature: Feature }) {
<Col span={ 24 }>
<Card className="card">
<Title level={ 4 }>Key</Title>
<p>Full Name: { keys[0].fullName }</p>
<p>Key Column: { keys[0].keyColumn }</p>
<p>Description: { keys[0].description }</p>
<p>Key Column Alias: { keys[0].keyColumnAlias }</p>
<p>Key Column Type: { keys[0].keyColumnType }</p>
<div className="feature-container">
<p>Full Name: { keys[0].fullName }</p>
<p>Key Column: { keys[0].keyColumn }</p>
<p>Description: { keys[0].description }</p>
<p>Key Column Alias: { keys[0].keyColumnAlias }</p>
<p>Key Column Type: { keys[0].keyColumnType }</p>
</div>
</Card>
</Col>
}
Expand All @@ -41,10 +43,12 @@ function FeatureType(props: { feature: Feature }) {
<Col span={ 24 }>
<Card className="card">
<Title level={ 4 }>Type</Title>
<p>Dimension Type: { type.dimensionType }</p>
<p>Tensor Category: { type.tensorCategory }</p>
<p>Type: { type.type }</p>
<p>Value Type: { type.valType }</p>
<div className="feature-container">
<p>Dimension Type: { type.dimensionType }</p>
<p>Tensor Category: { type.tensorCategory }</p>
<p>Type: { type.type }</p>
<p>Value Type: { type.valType }</p>
</div>
</Card>
</Col>
}
Expand All @@ -58,13 +62,15 @@ function FeatureTransformation(props: { feature: Feature }) {
<Col span={ 24 }>
<Card className="card">
<Title level={ 4 }>Transformation</Title>
{ transformation.transformExpr && <p>Expression: { transformation.transformExpr }</p> }
{ transformation.filter && <p>Filter: { transformation.filter }</p> }
{ transformation.aggFunc && <p>Aggregation: { transformation.aggFunc }</p> }
{ transformation.limit && <p>Limit: { transformation.limit }</p> }
{ transformation.groupBy && <p>Group By: { transformation.groupBy }</p> }
{ transformation.window && <p>Window: { transformation.window }</p> }
{ transformation.defExpr && <p>Expression: { transformation.defExpr }</p> }
<div className="feature-container">
{ transformation.transformExpr && <p>Expression: { transformation.transformExpr }</p> }
{ transformation.filter && <p>Filter: { transformation.filter }</p> }
{ transformation.aggFunc && <p>Aggregation: { transformation.aggFunc }</p> }
{ transformation.limit && <p>Limit: { transformation.limit }</p> }
{ transformation.groupBy && <p>Group By: { transformation.groupBy }</p> }
{ transformation.window && <p>Window: { transformation.window }</p> }
{ transformation.defExpr && <p>Expression: { transformation.defExpr }</p> }
</div>
</Card>
</Col>
}
Expand Down
7 changes: 7 additions & 0 deletions ui/src/site.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,10 @@
padding: 4px 12px 7px;
}

.feature-container {
column-count: 3;
}

.feature-container p {
break-inside: avoid-column;
}