Skip to content

Feathr UI: Show feature details when click feature in lineage graph #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blrchen merged 1 commit into from
Jun 10, 2022
Merged

Feathr UI: Show feature details when click feature in lineage graph #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/components/graph/graph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ const Graph: React.FC<Props> = ({ data, nodeId }) => {
if (isNode(element)) {
resetHighlight();
highlightPath(element, false);
setURLSearchParams({ nodeId: element.data.id });
setURLSearchParams({ nodeId: element.data.id, featureType: element.data.subtitle });
}
} }
onNodeDragStop={ onNodeDragStop }
Expand Down
87 changes: 87 additions & 0 deletions ui/src/components/graph/graphNodeDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
import React, { useEffect, useState } from 'react';
import { useParams, useSearchParams } from "react-router-dom";
import { fetchFeature } from '../../api';
import { Feature } from "../../models/model";
import { LoadingOutlined } from "@ant-design/icons";
import { Card, Spin } from "antd";

type Params = {
project: string;
featureId: string;
}

const GraphNodeDetails: React.FC = () => {
const [searchParams] = useSearchParams();
const { project } = useParams() as Params;
const nodeId = searchParams.get('nodeId') as string;
const featureType = searchParams.get('featureType') as string;
const [feature, setFeature] = useState<Feature>();
const [loading, setLoading] = useState<boolean>(false);

const isFeature = (featureType:string) => {
return featureType === 'feathr_anchor_feature_v1' || featureType === 'feathr_derived_feature_v1'
}

useEffect(() => {
const fetchFeatureData = async () => {
setFeature(undefined);
if (nodeId && isFeature(featureType)) {
setLoading(true);
const data = await fetchFeature(project, nodeId);
setFeature(data);
setLoading(false);
}
};

fetchFeatureData();
}, [nodeId]);

return (
<>
{
loading
? (<Spin indicator={ <LoadingOutlined style={ { fontSize: 24 } } spin /> } />)
: (<div style={ { margin: "2%" } }>
{ feature?.attributes.transformation &&
<Card title="Transformation">
{ feature.attributes.transformation.transform_expr &&
<p>transform_expr: { feature.attributes.transformation.transform_expr }</p> }
{ feature.attributes.transformation.filter &&
<p>filter: { feature.attributes.transformation.filter }</p> }
{ feature.attributes.transformation.agg_func &&
<p>agg_func: { feature.attributes.transformation.agg_func }</p> }
{ feature.attributes.transformation.limit &&
<p>limit: { feature.attributes.transformation.limit }</p> }
{ feature.attributes.transformation.group_by &&
<p>group_by: { feature.attributes.transformation.group_by }</p> }
{ feature.attributes.transformation.window &&
<p>window: { feature.attributes.transformation.window }</p> }
{ feature.attributes.transformation.def_expr &&
<p>def_expr: { feature.attributes.transformation.def_expr }</p> }
</Card>
}
{ feature?.attributes.key && feature.attributes.key.length > 0 &&
<Card title="Key">
<p>full_name: { feature.attributes.key[0].full_name }</p>
<p>key_column: { feature.attributes.key[0].key_column }</p>
<p>description: { feature.attributes.key[0].description }</p>
<p>key_column_alias: { feature.attributes.key[0].key_column_alias }</p>
<p>key_column_type: { feature.attributes.key[0].key_column_type }</p>
</Card>
}
{ feature?.attributes.type &&
<Card title="Type">
<p>dimension_type: { feature.attributes.type.dimension_type }</p>
<p>tensor_category: { feature.attributes.type.tensor_category }</p>
<p>type: { feature.attributes.type.type }</p>
<p>val_type: { feature.attributes.type.val_type }</p>
Comment thread
blrchen marked this conversation as resolved.
</Card>
}
</div>)
}
</>
)
}


export default GraphNodeDetails;
21 changes: 17 additions & 4 deletions ui/src/pages/feature/lineageGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import React, { useEffect, useState } from 'react';
import { Card, Radio, Spin } from 'antd';
import { Card, Col, Radio, Row, Spin } from 'antd';
import { useParams, useSearchParams } from "react-router-dom";
import { Elements } from 'react-flow-renderer';
import Graph from "../../components/graph/graph";
import { generateEdge, generateNode } from "../../components/graph/utils";
import { fetchProjectLineages } from "../../api";
import { FeatureLineage } from "../../models/model";
import { LoadingOutlined } from "@ant-design/icons";
import GraphNodeDetails from "../../components/graph/graphNodeDetails";

type Params = {
project: string;
Expand All @@ -24,6 +25,7 @@ const LineageGraph: React.FC = () => {
// Fetch lineage data from server side, invoked immediately after component is mounted
useEffect(() => {
const fetchLineageData = async () => {
setLoading(true);
const data = await fetchProjectLineages(project);
setLineageData(data);
setLoading(false);
Expand Down Expand Up @@ -105,9 +107,20 @@ const LineageGraph: React.FC = () => {
</Radio.Group>
</div>
<div>
{ loading
? <Spin indicator={ <LoadingOutlined style={ { fontSize: 24 } } spin /> } />
: <Graph data={ elements } nodeId={ nodeId } /> }
{
loading
? (<Spin indicator={ <LoadingOutlined style={ { fontSize: 24 } } spin /> } />)
: (
<Row>
<Col flex="2">
<Graph data={ elements } nodeId={ nodeId } />
</Col>
<Col flex="1">
<GraphNodeDetails></GraphNodeDetails>
</Col>
</Row>
)
}
</div>
</Card>
);
Expand Down