Skip to content

Consolidating CI pipelines #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoyongzhu merged 3 commits into from
May 18, 2022
Merged

Consolidating CI pipelines #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9040502
Combing workflows
jainr May 18, 2022
be67c89
Merge branch 'main' of github.com:linkedin/feathr into main
jainr May 18, 2022
a7fae70
Consolidating CI run workflows
jainr May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
166 changes: 0 additions & 166 deletions .github/workflows/main_merge_e2e.yml
View file
Open in desktop

This file was deleted.

28 changes: 20 additions & 8 deletions .github/workflows/pull_request_test.yml → .github/workflows/pull_request_push_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,30 @@
name: Feathr Scala Tests And Azure E2E Integration

on:
push:
branches: [main]
paths-ignore:
- 'docs/**'
- '**/README.md'
pull_request:
branches: [main]
paths-ignore:
- 'docs/**'
- '**/README.md'
pull_request_target:
types: [labeled]
paths-ignore:
- 'docs/**'
- '**/README.md'
branches: [main]
types: [labeled, edited, opened, synchronize]
paths-ignore:
- 'docs/**'
- '**/README.md'
jobs:
sbt_test:
runs-on: ubuntu-latest
if: contains(github.event.pull_request.labels.*.name, 'safe to test')
if: github.event_name == 'push' || github.event_name == 'pull_request' || (github.event_name == 'pull_request_target' && contains(github.event.pull_request.labels.*.name, 'safe to test'))
steps:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Set up JDK 8
uses: actions/setup-java@v2
with:
Expand All @@ -26,7 +34,7 @@ jobs:
run: sbt clean && sbt test
python_lint:
runs-on: ubuntu-latest
if: contains(github.event.pull_request.labels.*.name, 'safe to test')
if: github.event_name == 'push' || github.event_name == 'pull_request' || (github.event_name == 'pull_request_target' && contains(github.event.pull_request.labels.*.name, 'safe to test'))
steps:
- name: Set up Python 3.8
uses: actions/setup-python@v2
Expand All @@ -46,9 +54,11 @@ jobs:

databricks_test:
runs-on: ubuntu-latest
if: contains(github.event.pull_request.labels.*.name, 'safe to test')
if: github.event_name == 'push' || github.event_name == 'pull_request' || (github.event_name == 'pull_request_target' && contains(github.event.pull_request.labels.*.name, 'safe to test'))
steps:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Set up JDK 8
uses: actions/setup-java@v2
with:
Expand Down Expand Up @@ -110,9 +120,11 @@ jobs:
azure_synapse_test:
# might be a bit duplication to setup both the azure_synapse test and databricks test, but for now we will keep those to accelerate the test speed
runs-on: ubuntu-latest
if: contains(github.event.pull_request.labels.*.name, 'safe to test')
if: github.event_name == 'push' || github.event_name == 'pull_request' || (github.event_name == 'pull_request_target' && contains(github.event.pull_request.labels.*.name, 'safe to test'))
steps:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Set up JDK 8
uses: actions/setup-java@v2
with:
Expand Down