-
Notifications
You must be signed in to change notification settings - Fork 245
Feathr Web UI MVP #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feathr Web UI MVP #216
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e219d2d
Init react based feathr ui code (#1)
blrchen 2125737
Enables continues integration and deployment to cloud for ui app (#3)
blrchen dae5fc5
Add UI landing page
blrchen a4fcb8a
Workaround for CI treat warning as error
blrchen ba8f242
Enable client side route in Azure Static Web App
blrchen a171418
Code clean up
blrchen f2ae064
Code clean up
blrchen 3fb99ef
Enable eslint rules
blrchen e8c9f00
Update README.md
blrchen fb9886b
Fix CI error
blrchen 0d0ac94
Add data source mockup page
blrchen dfbfad4
Enable Azure AD login
blrchen a2eade0
Merge branch 'linkedin:main' into main
blrchen a3ceffd
Merge branch 'main' into blair/landing-page
blrchen c0cf941
Complete api integration
blrchen 0829447
Complete api integration
blrchen 00e71a3
Show lineage in feature detail page
blrchen 8c433bc
Resolve demo review comments
blrchen cc45acb
Update page title
blrchen 13e7611
Add lineage UI page
blrchen ba4e605
Update Web UI CICD file name and secret name
blrchen 48e8a88
Workaround for PR from forked branch can not access main repo's secret
blrchen 8870cec
Workaround for PR from forked branch can not access main repo's secret
blrchen 2adc13f
Resolve code review comments
blrchen 0ca7f07
Test use main repo's secret
blrchen 3940aca
Revert "Test use main repo's secret"
blrchen 7fbe247
Remove two more hard codings
blrchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| name: Feathr Web UI CI/CD on Azure Web App | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| types: [opened, synchronize, reopened, closed] | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| build_and_deploy_job: | ||
| if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed') | ||
| runs-on: ubuntu-latest | ||
| name: Build and Deploy Job | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| with: | ||
| submodules: true | ||
| - name: Build And Deploy | ||
| id: builddeploy | ||
| uses: Azure/static-web-apps-deploy@v1 | ||
| with: | ||
| azure_static_web_apps_api_token: ${{ secrets.AZURE_DEPLOYMENT_TOKEN_FEATHR_UI }} | ||
| repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for Github integrations (i.e. PR comments) | ||
| skip_deploy_on_missing_secrets: true | ||
| action: "upload" | ||
| ###### Repository/Build Configurations - These values can be configured to match your app requirements. ###### | ||
| # For more information regarding Static Web App workflow configurations, please visit: https://aka.ms/swaworkflowconfig | ||
| app_location: "/ui" # App source code path | ||
| api_location: "api" # Api source code path - optional | ||
| output_location: "build" # Built app content directory - optional | ||
| ###### End of Repository/Build Configurations ###### | ||
|
|
||
| close_pull_request_job: | ||
| if: github.event_name == 'pull_request' && github.event.action == 'closed' | ||
| runs-on: ubuntu-latest | ||
| name: Close Pull Request Job | ||
| steps: | ||
| - name: Close Pull Request | ||
| id: closepullrequest | ||
| uses: Azure/static-web-apps-deploy@v1 | ||
| with: | ||
| azure_static_web_apps_api_token: ${{ secrets.AZURE_DEPLOYMENT_TOKEN_FEATHR_UI }} | ||
| skip_deploy_on_missing_secrets: true | ||
| action: "close" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| { | ||
| "env": { | ||
| "commonjs": true, | ||
| "es6": true, | ||
| "node": true | ||
| }, | ||
| "extends": [ | ||
| // https://github.com/eslint/eslint/blob/main/conf/eslint-recommended.js | ||
| "eslint:recommended", | ||
| // https://github.com/facebook/create-react-app/tree/main/packages/eslint-config-react-app | ||
| "react-app" | ||
| ], | ||
| "parserOptions": { | ||
| "ecmaVersion": 2018, | ||
| "sourceType": "module" | ||
| }, | ||
| "rules": { | ||
| "dot-notation": "error" | ||
| }, | ||
| "overrides": [ | ||
| { | ||
| "files": [ | ||
| "**/*.ts?(x)" | ||
| ], | ||
| "rules": {} | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
|
||
| # dependencies | ||
| /node_modules | ||
| /.pnp | ||
| .pnp.js | ||
|
|
||
| # testing | ||
| /coverage | ||
|
|
||
| # production | ||
| /build | ||
|
|
||
| # misc | ||
| .DS_Store | ||
| .env.local | ||
| .env.development.local | ||
| .env.test.local | ||
| .env.production.local | ||
|
|
||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| # Feathr UI | ||
|
|
||
| This is Feathr web ui frontend code | ||
|
|
||
| ## Prerequisites | ||
| Install the latest version of [NodeJS](https://nodejs.org/en/) LTS v14.x or v16.x. Make sure to use npm no later than 6.x. Run **node --version** and **npm --version** to verify installed versions. | ||
|
|
||
| ## Build and run locally | ||
|
|
||
| Each command in this section should be run from the root directory of the repository. | ||
|
|
||
| Open terminal, go to root of this repository and run following commands. | ||
|
|
||
| ```bash | ||
| cd ui | ||
| npm install | ||
|
blrchen marked this conversation as resolved.
|
||
| npm start | ||
| ``` | ||
|
|
||
| This should launch [http://localhost:3000/](http://localhost:3000/) on your web browser. The page will reload when you make code changes and save. | ||
|
|
||
| ## Deploying | ||
|
|
||
| For deployment, run `npm run build` and upload `build/` to your server. Docker image based deployment is coming soon. | ||
|
|
||
| ## Lint | ||
|
|
||
| To lint typescript code files, sim run: | ||
| ```bash | ||
| npm run lint:fix | ||
| ``` | ||
|
|
||
| This command will Automatically fix all problems that can be fixed, and list the rest problems requires manual fix. | ||
| Linting rules are configured in [.eslintrc](.eslintrc) file. | ||
|
|
||
| ## Project Structure | ||
|
|
||
| ``` | ||
| src/ | ||
| api // rest client | ||
| components // shared react components | ||
| models // api data model, view model, etc | ||
| pages // a view on the page, can be routed by url path | ||
| router // url path and page mapping | ||
| ``` | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.