Synchronize horizontal/vertical classes.#207
Merged
Merged
Conversation
Member
|
Overall, these mostly seem like good changes. I'll need to test them a bit more thoroughly before I merge, though. One place where I think you got something wrong is the layout of the tracks on VScrollBar and VSlider. The maximum value of VSlider is at the top. But the maximum value of VScrollBar is at the bottom. So their layout code should actually be a bit different. |
Contributor
Author
|
Ah right, I remember being confused by those another time too. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a tool I wrote, I found several inconsistencies in the "Horizontal" and "Vertical" classes.
These range from meaningless (e.g., line order) to inaccurate documentation (e.g., a default being listed as 5.0 when it's null) to possible errors (e.g., adding
adjustedGapinstead of dividing by it).