Skip to content

upgrate swagger to 2.0 - #12

Merged
daffl merged 11 commits into
feathersjs-ecosystem:masterfrom
lpreterite:master
Oct 14, 2016
Merged

daffl merged 11 commits into
feathersjs-ecosystem:masterfrom
lpreterite:master

Conversation

@lpreterite

Copy link
Copy Markdown
Contributor

No description provided.

@daffl

daffl commented Oct 13, 2016

Copy link
Copy Markdown
Member

I like where this is going 😃 One question:

Is there a Swagger NPM module so that we don't have to check in the bower_components?

@daffl

daffl commented Oct 13, 2016

Copy link
Copy Markdown
Member

E.g. adding https://www.npmjs.com/package/swagger-ui to the dependencies and linking to it?

@lpreterite

Copy link
Copy Markdown
Contributor Author

I was going to use NPM module instead of bower :-)

@daffl

daffl commented Oct 14, 2016

Copy link
Copy Markdown
Member

Sweet. If you can update the pull request to use it we can start getting an updated release ready 😄

@daffl
daffl merged commit 17a9ff1 into feathersjs-ecosystem:master Oct 14, 2016
@daffl

daffl commented Oct 14, 2016

Copy link
Copy Markdown
Member

Thank you again, this is great! I will try and update the plugin to our new infrastructure over the weekend, add some tests and make a v0.3.0 release.

@daffl

daffl commented Nov 22, 2016

Copy link
Copy Markdown
Member

@lpreterite Thanks again! I released the updated version as 0.3.0. One thing I changed was moving things like new feathersSwagger.utils.Definition to feathersSwagger.definition, everything else should still work the same.

@lpreterite

Copy link
Copy Markdown
Contributor Author

Another problem in this version, property type not converted successfully, please update the following code

# utils.js@definition
keys.forEach(function (attrName) {
    let attr = model.attributes[attrName];
    let attrType = typeof attr.key !== 'undefined' ? attr.key : attr.type.constructor.prototype.key;
    var prop = property(attrType, model.attributes[attrName].type);

    result.properties[attrName] = prop;
});

@daffl daffl mentioned this pull request Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants