Skip to content

Duplicate redisClient (bug fix) * Customize subscriber event #155

Closed
dubiousdavid wants to merge 5 commits into
feathersjs:masterfrom
dubiousdavid:master
Closed

Duplicate redisClient (bug fix) * Customize subscriber event #155
dubiousdavid wants to merge 5 commits into
feathersjs:masterfrom
dubiousdavid:master

Conversation

@dubiousdavid
Copy link
Copy Markdown
Contributor

  • Allow for the customization of the subscriber event to use message buffers with ioredis. Could also be useful for the redis package.
  • Duplicate redisClient since we need two connections, one for publish and one for subscribe.

@dubiousdavid dubiousdavid changed the title Master Duplicate redisClient (bug fix) * Customize subscriber event Jan 21, 2021
@daffl
Copy link
Copy Markdown
Member

daffl commented Jan 23, 2021

This makes sense, thank you! Two things:

  1. Could you re-submit the PR against the latest development branch instead of master?
  2. No need to update version numbers, that will happen automatically during release

@dubiousdavid
Copy link
Copy Markdown
Contributor Author

Will do.

@dubiousdavid
Copy link
Copy Markdown
Contributor Author

New PR: #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants