Added option to grab created resource id from original data object.#63
Merged
daffl merged 1 commit intoSep 14, 2016
Merged
Conversation
… of the return object.
This was referenced Aug 2, 2016
| return this.db().insert(data, this.id).then(rows => this._get(rows[0], params)) | ||
| .catch(errorHandler); | ||
| return this.db().insert(data, this.id).then(rows => { | ||
| const id = this.idFromData ? data[this.id] : rows[0]; |
Member
There was a problem hiding this comment.
Does it need to be an option flag? I feel we could just fairly safely assume const id = typeof data[this.id] !== 'undefined' ? data[this.id] : rows[0] right?
Contributor
Author
There was a problem hiding this comment.
Yeah good call, an option is totally unnecessary
Member
|
One comment and a tests for this would be sweet 😄 |
Contributor
Author
|
Cool I'll whip something up this week |
Member
|
Cool, let me know. I can get to it as well if you are too busy so that we can get this out in a new release. |
Member
|
Any news? I still think it would be a good fix with the changes we discussed. |
daffl
added a commit
that referenced
this pull request
Sep 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe somebody can come up with a better option name??