Skip to content

fix(authentication-oauth): Use actual URL origin comparison for origin check #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 2 commits into from
Mar 21, 2026
+41 −9
Merged

fix(authentication-oauth): Use actual URL origin comparison for origin check #3676

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ffd075
fix(authentication-oauth): Use actual URL origin comparison for origi…
daffl Mar 19, 2026
3fd26b5
Nits
daffl Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Nits
  • Loading branch information
@daffl
daffl committed Mar 21, 2026
commit 3fd26b5e6077839bc492b7912c67aaf1c6bf5391
4 changes: 2 additions & 2 deletions packages/authentication-oauth/src/strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,11 @@ export class OAuthStrategy extends AuthenticationBaseStrategy {
return null
}

const redirectUrl = `${redirect}${queryRedirect}`

if (queryRedirect) {
validateRedirectOrigin(redirect, queryRedirect)
}

const redirectUrl = `${redirect}${queryRedirect}`
const separator = redirectUrl.endsWith('?') ? '' : redirect.indexOf('#') !== -1 ? '?' : '#'
const authResult: AuthenticationResult = data
const query = authResult.accessToken
Expand Down
Loading