Skip to content

feat: Chainable @hooks().params() decorator with hookMixin support #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marshallswain wants to merge 7 commits into from
Closed

feat: Chainable @hooks().params() decorator with hookMixin support #3650

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6044134
feat(hooks): Add chainable @hooks().params() decorator syntax
marshallswain Jan 31, 2026
ed6d650
feat: hookMixin respects custom params from @hooks().params() decorator
marshallswain Jan 31, 2026
1f684b4
docs: add documentation for chainable @hooks().params() decorator
marshallswain Jan 31, 2026
6f3e99d
refactor: DRY up chainable decorator and hookMixin implementation
marshallswain Jan 31, 2026
acf79c2
refactor: simplify Feathers context prop helpers
marshallswain Jan 31, 2026
4f878f6
refactor: use public HookManager API in chainable decorator
marshallswain Jan 31, 2026
be6dde7
fix: prefix unused test params with underscore to satisfy eslint
marshallswain Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: prefix unused test params with underscore to satisfy eslint
  • Loading branch information
@marshallswain
marshallswain committed Jan 31, 2026
commit be6dde7885c39217800306ea168e08238aa1823c
6 changes: 3 additions & 3 deletions packages/feathers/src/hooks/decorator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ describe('feathers/hooks chainable decorator', () => {
.params('id', 'params')
.props({ service: 'messages' })
.defaults(() => ({ timestamp: 99999 })))
async status(id: string, params: any) {
async status(id: string, _params: any) {
return { id, status: 'active' }
}
}
Expand Down Expand Up @@ -246,7 +246,7 @@ describe('hookMixin respects @hooks().params()', () => {
await next()
}
])
async create(data: any, params?: any) {
async create(data: any, _params?: any) {
return data
}
}
Expand Down Expand Up @@ -328,7 +328,7 @@ describe('hookMixin respects @hooks().params()', () => {
.params('id', 'options')
.props({ serviceName: 'status' })
.defaults(() => ({ timestamp: 99999 })))
async check(id: string, options?: any) {
async check(id: string, _options?: any) {
return { id, status: 'ok' }
}
}
Expand Down
Loading