Skip to content

Fix custom hook methods for typed client #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laurensiusadi wants to merge 1 commit into
base: dove
Choose a base branch
from
+1 −1
Open

Fix custom hook methods for typed client #3640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix custom hook methods for typed client 
Filter hook methods to include only those that are functions to prevent error "Can not apply hooks" in the typed client
  • Loading branch information
@laurensiusadi
laurensiusadi authored Jan 20, 2026
commit d51dc61623ce969a743105ef11c3d6102cb554a5
2 changes: 1 addition & 1 deletion packages/feathers/src/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export function getHookMethods(service: any, options: ServiceOptions) {

return (defaultServiceMethods as any as string[])
.filter((m) => typeof service[m] === 'function' && !methods.includes(m))
.concat(methods)
.concat(methods.filter((m) => typeof service[m] === 'function'))
}

export function getServiceOptions(service: any): ServiceOptions {
Expand Down
Loading