Skip to content

V6 pluggable router #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marshallswain wants to merge 3 commits into
base: v6
Choose a base branch
from
Open

V6 pluggable router #3606

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4307a3
feat: Add pluggable router to reduce Express dependency
marshallswain Sep 4, 2025
1a7b51e
fix(routing): optimize lookup performance and expose router options
marshallswain Dec 19, 2025
a8d3619
fix(routing): add type check for non-string paths in lookup
marshallswain Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(routing): add type check for non-string paths in lookup
  • Loading branch information
@marshallswain
marshallswain committed Dec 19, 2025
commit a8d36191e0aa88f859c04e70dc1cd16b860945ee
10 changes: 10 additions & 0 deletions packages/routing/src/base-router.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,14 @@ describe('BaseRouter', () => {
assert.ok(result2)
assert.deepStrictEqual(result2.params['path'], ['a', 'b', 'c'])
})

it('returns null for non-string paths', () => {
const router = new TestRouter()
router.insert('/users', 'users-handler')

assert.strictEqual(router.lookup(null as any), null)
assert.strictEqual(router.lookup(undefined as any), null)
assert.strictEqual(router.lookup(123 as any), null)
assert.strictEqual(router.lookup({} as any), null)
})
})
4 changes: 4 additions & 0 deletions packages/routing/src/base-router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ export abstract class BaseRouter<T = any> implements RouterInterface<T> {
}

lookup(path: string): LookupResult<T> | null {
if (typeof path !== 'string') {
return null
}

const normalizedPath = normalizePath(path)

for (const route of this.routes) {
Expand Down
Loading