Skip to content

feat: ES module build #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daffl wants to merge 13 commits into from
Closed

feat: ES module build #3375

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
92e9211
feat: ES Module build
daffl Dec 22, 2023
e5fc686
Update src/ paths
daffl Dec 22, 2023
2822ef5
Migrate commons and errors
daffl Dec 22, 2023
b5e4173
adapter-commons ES module
daffl Dec 22, 2023
eab04b9
adapter-tests ES module
daffl Dec 22, 2023
4ca1ab6
authentication ES modules
daffl Dec 22, 2023
03ed621
configuration and express ES module
daffl Dec 22, 2023
347be8b
database adapter es modules
daffl Dec 22, 2023
3d8c813
schema and typebox es module
daffl Dec 22, 2023
414f3d8
koa and socketio es module
daffl Dec 22, 2023
a7c88b9
rest and socketio client es modules
daffl Dec 22, 2023
5af879a
Finalise ES module migration
daffl Dec 22, 2023
1af1513
Add missing dependency and update package-lock.json
daffl Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rest and socketio client es modules
  • Loading branch information
@daffl
daffl committed Dec 22, 2023
commit a7c88b9028952116b4be584eb03222cda9ce01d5
26 changes: 19 additions & 7 deletions packages/rest-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"description": "REST client services for different Ajax libraries",
"version": "5.0.12",
"homepage": "https://feathersjs.com",
"main": "lib/",
"types": "lib/",
"main": "./lib/index.js",
"types": "./types/index.d.ts",
"keywords": [
"feathers",
"feathers-plugin"
Expand All @@ -29,22 +29,26 @@
"url": "https://github.com/feathersjs/feathers/issues"
},
"engines": {
"node": ">= 12"
"node": ">= 18"
},
"files": [
"CHANGELOG.md",
"LICENSE",
"README.md",
"src/**",
"lib/**",
"types/**",
"esm/**",
"*.d.ts",
"*.js"
],
"scripts": {
"prepublish": "npm run compile",
"pack": "npm pack --pack-destination ../generators/test/build",
"compile": "shx rm -rf lib/ && tsc && npm run pack",
"test": "mocha --config ../../.mocharc.json --recursive test/**.test.ts test/**/*.test.ts"
"compile": "npm run compile:cjs && npm run compile:esm && npm run pack",
"test": "mocha --config ../../.mocharc.json --recursive test/**.test.ts test/**/*.test.ts",
"compile:esm": "shx rm -rf esm/ && tsc --outDir esm/ --module esnext && shx echo '{ \"type\": \"module\" }' > esm/package.json",
"compile:cjs": "npx shx rm -rf types/ lib/ && tsc && shx echo '{ \"type\": \"commonjs\" }' > lib/package.json"
},
"directories": {
"lib": "lib"
Expand Down Expand Up @@ -76,5 +80,13 @@
"ts-node": "^10.9.2",
"typescript": "^5.3.3"
},
"gitHead": "90caf635aec850550b9d37bea2762af959d9e8d5"
}
"gitHead": "90caf635aec850550b9d37bea2762af959d9e8d5",
"module": "./esm/index.js",
"exports": {
".": {
"import": "./esm/index.js",
"require": "./lib/index.js",
"types": "./types/index.d.ts"
}
}
}
5 changes: 3 additions & 2 deletions packages/rest-client/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"src/**/*.ts"
],
"compilerOptions": {
"outDir": "lib"
"declarationDir": "./types",
"outDir": "lib"
}
}
}
0 packages/transport-commons/src/client.ts → packages/socketio-client/src/client.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/socketio-client/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { Service, SocketService } from '@feathersjs/transport-commons/client'
import { Socket } from 'socket.io-client'
import {
Application,
TransportConnection,
defaultEventMap,
defaultServiceMethods
} from '@feathersjs/feathers'
import { Service, SocketService } from './client'

export { SocketService }

Expand Down
0 ...ges/transport-commons/test/client.test.ts → packages/socketio-client/test/client.test.ts
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion packages/transport-commons/client.d.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/transport-commons/client.js
View file
Open in desktop

This file was deleted.

24 changes: 18 additions & 6 deletions packages/transport-commons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"description": "Shared functionality for websocket providers",
"version": "5.0.12",
"homepage": "https://feathersjs.com",
"main": "lib/",
"types": "lib/",
"main": "./lib/index.js",
"types": "./types/index.d.ts",
"keywords": [
"feathers",
"feathers-plugin"
Expand All @@ -29,14 +29,16 @@
"url": "https://github.com/feathersjs/feathers/issues"
},
"engines": {
"node": ">= 12"
"node": ">= 18"
},
"scripts": {
"prepublish": "npm run compile",
"pack": "npm pack --pack-destination ../generators/test/build",
"compile": "shx rm -rf lib/ && tsc && npm run pack",
"compile": "npm run compile:cjs && npm run compile:esm && npm run pack",
"test": "npm run mocha",
"mocha": "mocha --config ../../.mocharc.json --recursive test/**.test.ts test/**/*.test.ts"
"mocha": "mocha --config ../../.mocharc.json --recursive test/**.test.ts test/**/*.test.ts",
"compile:esm": "shx rm -rf esm/ && tsc --outDir esm/ --module esnext && shx echo '{ \"type\": \"module\" }' > esm/package.json",
"compile:cjs": "npx shx rm -rf types/ lib/ && tsc && shx echo '{ \"type\": \"commonjs\" }' > lib/package.json"
},
"directories": {
"lib": "lib"
Expand All @@ -50,6 +52,8 @@
"README.md",
"src/**",
"lib/**",
"types/**",
"esm/**",
"*.d.ts",
"*.js"
],
Expand All @@ -70,5 +74,13 @@
"ts-node": "^10.9.2",
"typescript": "^5.3.3"
},
"gitHead": "90caf635aec850550b9d37bea2762af959d9e8d5"
"gitHead": "90caf635aec850550b9d37bea2762af959d9e8d5",
"module": "./esm/index.js",
"exports": {
".": {
"import": "./esm/index.js",
"require": "./lib/index.js",
"types": "./types/index.d.ts"
}
}
}
5 changes: 3 additions & 2 deletions packages/transport-commons/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"src/**/*.ts"
],
"compilerOptions": {
"outDir": "lib"
"declarationDir": "./types",
"outDir": "lib"
}
}
}