chore: add directories to package.json-repository#2582
Merged
daffl merged 1 commit intofeathersjs:dovefrom Mar 24, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For packages like
@feathersjs/transport-commons,adapter-commonsor even@feathersjs/featherson npmjs.com I had trouble to find the corresponding folder in this monorepo.package.jsonallows arepository.directoryproperty to define the subdirectory in a mono-repo. By doing that, the click on the repository on npmjs.com lead directly to the sub directory of the package. On https://www.npmjs.com/package/@feathersjs/adapter-commons it's even worse because it leads to https://github.com/feathersjs/databases...npm docs say:
{ "repository": { "type": "git", "url": "https://github.com/facebook/react.git", "directory": "packages/react-dom" } }So, the repository url on each
@feathersjs/...package leads to the subdirectory of the github repo.