Skip to content

chore: add directories to package.json-repository#2582

Merged
daffl merged 1 commit intofeathersjs:dovefrom
fratzinger:repo-url
Mar 24, 2022
Merged

chore: add directories to package.json-repository#2582
daffl merged 1 commit intofeathersjs:dovefrom
fratzinger:repo-url

Conversation

@fratzinger
Copy link
Copy Markdown
Member

@fratzinger fratzinger commented Mar 15, 2022

For packages like @feathersjs/transport-commons, adapter-commons or even @feathersjs/feathers on npmjs.com I had trouble to find the corresponding folder in this monorepo. package.json allows a repository.directory property to define the subdirectory in a mono-repo. By doing that, the click on the repository on npmjs.com lead directly to the sub directory of the package. On https://www.npmjs.com/package/@feathersjs/adapter-commons it's even worse because it leads to https://github.com/feathersjs/databases...

npm docs say:

If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives:

{
  "repository": {
    "type": "git",
    "url": "https://github.com/facebook/react.git",
    "directory": "packages/react-dom"
  }
}

So, the repository url on each @feathersjs/... package leads to the subdirectory of the github repo.

image

@daffl daffl merged commit 5e8b9a3 into feathersjs:dove Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants