Skip to content

fix(adapter-tests): Add tests for pagination in multi updates #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 8 commits into from
Feb 15, 2022
Merged

fix(adapter-tests): Add tests for pagination in multi updates #2472

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8127d82
Merge pull request #19 from feathersjs/dove
fratzinger Oct 15, 2021
16effb3
test(adapter-tests): add patch multiple paginate test
Oct 16, 2021
9d5d8ad
test(memory): add patch multiple paginate test
Oct 16, 2021
90d54c1
chore(memory): remove unneccesary mocha spec
Oct 16, 2021
59410bb
test(adapter-tests): add check for default pagination in find
Oct 16, 2021
7d21eb8
test(adapter-tests): add multi:remove with default pagination test
Oct 16, 2021
4305459
test(memory): test for remove:multi with default paginate
Oct 16, 2021
8c395f9
test: test for no pagination instead of default pagination
fratzinger Jan 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(adapter-tests): add multi:remove with default pagination test
  • Loading branch information
fratzinger committed Oct 16, 2021
commit 7d21eb8fbb98e090ee2b48b4ee4b62944ea9dc11
1 change: 1 addition & 0 deletions packages/adapter-tests/src/declarations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export type AdapterMethodsTestName =
'.remove + $select' |
'.remove + id + query' |
'.remove + multi' |
'.remove + multi default pagination' |
'.remove + id + query id' |
'.update' |
'.update + $select' |
Expand Down
60 changes: 60 additions & 0 deletions packages/adapter-tests/src/methods.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,66 @@ export default (test: AdapterMethodsTest, app: any, _errors: any, serviceName: s
assert.ok(names.includes('David'), 'David removed');
});

test('.remove + multi default pagination', async () => {
try {
await service.remove(doug[idProp]);
} catch (error: any) {}

const count = 14;
const defaultPaginate = 10;

assert.ok(count > defaultPaginate, 'count is bigger than default pagination');

const multiBefore = service.options.multi;
const paginateBefore = service.options.paginate;

try {
service.options.multi = true;
service.options.paginate = {
'default': defaultPaginate,
'max': 100
};

let emptyItems = await service.find({ paginate: false });
assert.strictEqual(emptyItems.length, 0, 'no entries before')

const createdItems = await service.create(
Array.from(Array(count)).map((_, i) => ({ name: `name-${i}`, age: 3, created: true }))
);
assert.strictEqual(createdItems.length, count, `created ${count} entries`);

let foundItems = await service.find({ paginate: false });
assert.strictEqual(foundItems.length, count, `created ${count} entries`);

const foundPaginatedItems = await service.find({});
assert.strictEqual(foundPaginatedItems.data.length, defaultPaginate, 'found paginated data');

const data1 = await service.remove(null, { query: { created: true }, paginate: false });

assert.strictEqual(data1.length, count, `returned all ${ count } entries`);

emptyItems = await service.find({ paginate: false });
assert.strictEqual(emptyItems.length, 0, 'no entries before')

await service.create(
Array.from(Array(count)).map((_, i) => ({ name: `name-${i}`, age: 3, created: true }))
);

foundItems = await service.find({ paginate: false });
assert.strictEqual(foundItems.length, count, `created ${count} entries`);

const data2 = await service.remove(null, { query: { created: true } });

assert.strictEqual(data2.length, defaultPaginate, `returned paginated ${ defaultPaginate } entries`);

} finally {
await service.remove(null, { query: { created: true }, paginate: false });

service.options.multi = multiBefore;
service.options.paginate = paginateBefore;
}
});

test('.remove + id + query id', async () => {
const alice = await service.create({
name: 'Alice',
Expand Down