Repository navigation
chore: Updated typings - #2384
Merged
Merged
Conversation
Member
|
Great, thank you! Hopefully we can eventually get everything (including the internal codebase) working with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current generated type definitions for
JwtStrategyis as follows:This backwards-compatible PR updates the type definition to:
This is to allow other projects with
strictNullChecksto sub-classJwtStrategyand able to compile without any errors.node_modules/feathers-authentication-oidc/lib/OidcStrategy.d.ts:9:5 - error TS2416: Property 'parse' in type 'OidcStrategy' is not assignable to the same property in base type 'JWTStrategy'. Type '(req: IncomingMessage) => Promise<{ strategy: string; accessToken: string; } | null>' is not assignable to type '(req: IncomingMessage) => Promise<{ strategy: string; accessToken: string; }>'. Type 'Promise<{ strategy: string; accessToken: string; } | null>' is not assignable to type 'Promise<{ strategy: string; accessToken: string; }>'. Type '{ strategy: string; accessToken: string; } | null' is not assignable to type '{ strategy: string; accessToken: string; }'. Type 'null' is not assignable to type '{ strategy: string; accessToken: string; }'. 9 parse(req: IncomingMessage): Promise<{