Skip to content

Fix SSTable name length restrictions during ingestion #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
May 10, 2021
Merged

Fix SSTable name length restrictions during ingestion #70

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf5f293
Add table name length limit for ingestion
terryyylim May 5, 2021
f72de52
Address comments
terryyylim May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address comments 
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
  • Loading branch information
@terryyylim
terryyylim committed May 7, 2021
commit f72de527253c98c09391753c69af1257ed7a1f86
3 changes: 2 additions & 1 deletion spark/ingestion/src/main/scala/feast/ingestion/utils/StringUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ object StringUtils {
}

def trimAndHash(expr: String, maxLength: Int): String = {
val maxPrefixLength = 40
// Length 8 suffix as derived from murmurhash_32 implementation
val maxPrefixLength = maxLength - 8
if (expr.length > maxLength)
expr
.take(maxPrefixLength)
Expand Down