Revert changes on pipeline connection initialization#154
Merged
khorshuheng merged 2 commits intofeast-dev:masterfrom Jun 29, 2022
Merged
Revert changes on pipeline connection initialization#154khorshuheng merged 2 commits intofeast-dev:masterfrom
khorshuheng merged 2 commits intofeast-dev:masterfrom
Conversation
af91a3d to
7bb173d
Compare
…feast-dev#152)" This reverts commit 58ebe0f. Signed-off-by: khorshuheng <khor.heng@gojek.com>
…der (feast-dev#144)" This reverts commit fcb80a0. Signed-off-by: khorshuheng <khor.heng@gojek.com>
7bb173d to
d544c2e
Compare
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: keshav2211, khorshuheng The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#152 doesn't work because RedisSinkRelation is instantiated multiple times for the streaming job. We have also observed that #144 still result in some connection leaks.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: