Skip to content

Add redis timeout configuration option & Serving Configuration Refactoring #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyalex merged 6 commits into from
Mar 5, 2021
Merged

Add redis timeout configuration option & Serving Configuration Refactoring #8

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd90460
add redis timeout option
pyalex Mar 4, 2021
b311905
fix typo
pyalex Mar 4, 2021
83b4ef1
remove StoreProto.Store
pyalex Mar 4, 2021
b7cfc91
remove StoreProto.Store
pyalex Mar 4, 2021
8ec4861
fix test
pyalex Mar 4, 2021
7eb226d
clean up
pyalex Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test 
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
  • Loading branch information
@pyalex
pyalex committed Mar 4, 2021
commit 8ec486176689f71eb1ee9e129f6d895a0fef2808
7 changes: 0 additions & 7 deletions serving/src/test/java/feast/serving/service/CachedSpecServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@

import static org.hamcrest.CoreMatchers.equalTo;
import static org.junit.Assert.assertThat;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import static org.mockito.MockitoAnnotations.initMocks;

Expand Down Expand Up @@ -114,11 +112,6 @@ private void setupFeatureTableAndProject(String project) {
.build());
}

@Test
public void shouldRegisterStoreWithCore() {
verify(coreService, times(1)).registerStore(cachedSpecService.getStore());
}

@Test
public void shouldPopulateAndReturnDifferentFeatureTables() {
// test that CachedSpecService can retrieve fully qualified feature references.
Expand Down